SVG export: add 'Z' close-path command for closed contours - #1737
Merged
Conversation
Member
|
@AnibalPinto It might be better to add a "IsClosed" flag for the FinishPath function and pass the flag to that. Then in the SVG version of FinishPath, check the flag and output the Z as needed there. I think this is maybe better than adding a new virtual function just for this. This is also something we don't need a test case for. |
Contributor
Author
|
@phkahler thanks for the notification. It changes more code but avoid more functions. I tried to use clang to check format but or I am doing something wrong or format isn't used. |
Fixes solvespace#1368. For closed paths (loops), the SVG path definition now ends with 'Z' to explicitly close the path, rather than relying on the last point being equal to the first point. Modified FinishPath with information if path is closed and SVG export append an Z when path is closed.
AnibalPinto
force-pushed
the
master-issue1368
branch
from
August 11, 2026 07:16
5bdeccc to
ff864ee
Compare
Member
|
Thanks for this. Better file output is always good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1368.
For closed paths (loops), the SVG path definition now ends with 'Z' to explicitly close the path, rather than relying on the last point being equal to the first point.