Fix to use output of unsqueeze() in Tacotron2 parse_decoder_outputs()#1525
Merged
Conversation
Collaborator
|
Hi @jqug, thank you for pointing this out, could you please finish the CI test so that we can finally merge this fix? (Please first pull the latest commits) |
Collaborator
|
Hi @jqug please fetch the latest develop branch into your PR branch. The merger is blocked on our side by a testing error It goes without saying, this error has another cause—other PRs faced it also (in short, it was for updates in dependencies); we fixed it some weeks ago. Yet, all PRs need to fetch that fix into their branch; for which, please fetch the latest develop branch. Then, we can re-run the tests and get much closer to an "ok" for merger :) |
BenoitWang
approved these changes
Sep 18, 2022
Contributor
Author
|
Thanks @BenoitWang and @anautsch - I've pulled the recent changes, let me know if any other action is needed. |
anautsch
approved these changes
Sep 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, this is a fix for an issue where an extra dimension of gate_outputs was not being added (since unsqueeze() doesn't operate inplace). In case the Tacotron2 model generates only a single frame of output, this would cause a failure downstream when parsing the model output.
Thanks for all the work on this great project!