Skip to content

bug-fix: fixed OPEN_RIR data preparation process conflict.#1536

Merged
anautsch merged 2 commits into
speechbrain:developfrom
xin-w8023:bug-fix/fix-aug-prepare-conflict
Aug 31, 2022
Merged

bug-fix: fixed OPEN_RIR data preparation process conflict.#1536
anautsch merged 2 commits into
speechbrain:developfrom
xin-w8023:bug-fix/fix-aug-prepare-conflict

Conversation

@xin-w8023

Copy link
Copy Markdown
Contributor

if not os.path.isdir(os.path.join(folder, "RIRS_NOISES")):

None main process might skip the following block if main process already got in and created the folder.

@xin-w8023 xin-w8023 changed the title bug-fixed: fixed OPEN_RIR data preparation process conflict. bug-fix: fixed OPEN_RIR data preparation process conflict. Aug 10, 2022
@anautsch

Copy link
Copy Markdown
Collaborator

@xin-w8023 lgtm - thank you for this contribution!

Can you please fetch the latest develop branch into your local branch?
Then, we can re-run the tests (they should work out just fine then), and merge.

@xin-w8023

xin-w8023 commented Aug 31, 2022

Copy link
Copy Markdown
Contributor Author

@xin-w8023 lgtm - thank you for this contribution!

Can you please fetch the latest develop branch into your local branch? Then, we can re-run the tests (they should work out just fine then), and merge.

@anautsch hi, I just push Sync Fork button, but this seems like introducing an extra commit, is that ok? Or should I rebase to the latest develop manually?

@anautsch

Copy link
Copy Markdown
Collaborator

@xin-w8023 let's see - this is normal; don't worry. One commit more in the tree won't hurt - git should handle it automatically.

@anautsch anautsch merged commit 4b3bf60 into speechbrain:develop Aug 31, 2022
@xin-w8023 xin-w8023 deleted the bug-fix/fix-aug-prepare-conflict branch August 31, 2022 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants