Fix Issue #1277 timit recipe missing uppercase option #1564
Conversation
|
lgtm - some thoughts on an adjacent issue. This was not detected by yaml tests, although they consider data preparation scripts - why? While the recipe overview has the data preparation script referenced, it plays a litter role for the yaml testin. speechbrain/speechbrain/utils/check_yaml.py Line 129 in 424e792 Should testing include that through YAML one could specify parameters of any subfunction? |
Hmm according to the doc string of speechbrain/speechbrain/utils/check_yaml.py Line 129 in 424e792 Not sure to understand clearly your last paragraph. |
You got it; don't worry. I'd see that as a part of functionality for that testing script, whereas it is currently not. It's literally up to us to make it function/or not. Yet the existence of this PR demonstrates: it should be part of function. Question is: what's the least effort here - writing a new testing script; reusing the old one; some hybrid approach - or simply fixing this instance and waiting until it pops up elsewhere again 😉 |
Small fix for #1277