🖍️ improving type-hints in speechbrain/pretrained/interfaces.py#1725
Merged
Conversation
jonasvdd
commented
Nov 28, 2022
| inputs = [ | ||
| { | ||
| "text_sequences": torch.tensor( | ||
| "text_sequences": torch.Tensor( |
Contributor
Author
There was a problem hiding this comment.
Whoops. Accidentally altered this one. Will fix it in a new commit.
Contributor
Author
There was a problem hiding this comment.
Should be fixed now!
Contributor
Author
|
In f372dff, I fix some more typos throughout the whole interfaces.py file! 😄 |
Adel-Moumen
approved these changes
Dec 27, 2022
Adel-Moumen
left a comment
Collaborator
There was a problem hiding this comment.
LGTM!
Thanks a lot for the PR, you did a great job! I wish you an happy new year :-)
Contributor
Author
|
Happy holidays for you as well! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is not a big PR, but at least it is honest work 😅
This PR:
boundaryargument (was set tostrtype, but must betorch.Tensor).torch.Tensorwhich is more correct. See 📷 ⬇️