Skip to content

Refactor ESC50 recipes and add FocalNets#2499

Merged
mravanelli merged 11 commits into
speechbrain:developfrom
lucadellalib:interpretability-focalnets
Apr 14, 2024
Merged

Refactor ESC50 recipes and add FocalNets#2499
mravanelli merged 11 commits into
speechbrain:developfrom
lucadellalib:interpretability-focalnets

Conversation

@lucadellalib

Copy link
Copy Markdown
Collaborator

Addressed the comments from #2388.

@ycemsubakan

Copy link
Copy Markdown
Collaborator

To me, the new file structure looks great. After the cyclic import issue is fixed, we can merge this PR.

@mravanelli mravanelli added the enhancement New feature or request label Apr 12, 2024
@mravanelli

Copy link
Copy Markdown
Collaborator

Thank you @lucadellalib for this PR!
Here are my comments:

  1. recipe tests are failing (recipes/ESC50/interpret/hparams/amt_focalnet.yaml, recipes/ESC50/interpret/hparams/amt_vit.yaml, recipes/ESC50/interpret/hparams/piq_focalnet.yaml, recipes/ESC50/interpret/hparams/piq_vit.yaml) => "ValueError: 'embedding_model_path' is a !PLACEHOLDER and must be replaced." Please, run them with:
    python -c 'from tests.utils.recipe_tests import run_recipe_tests; print("TEST FAILED!") if not(run_recipe_tests(filters_fields=["Dataset"], filters=[["ESC50"]], do_checks=True, run_opts="--device=cuda")) else print("TEST PASSED")'

  2. Please, share the models with me such that I can upload them on the official dropbox.

  3. Just like the other methods, I recommend putting the model on HF as well. This way, users can directly run the interpretation script (nterpret_amt.py) before training the classifier.

@mravanelli

Copy link
Copy Markdown
Collaborator

Thank you @lucadellalib for this PR. Everything now works properly.

@mravanelli mravanelli merged commit afd3423 into speechbrain:develop Apr 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants