You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thank you @lucadellalib for this PR!
Here are my comments:
recipe tests are failing (recipes/ESC50/interpret/hparams/amt_focalnet.yaml, recipes/ESC50/interpret/hparams/amt_vit.yaml, recipes/ESC50/interpret/hparams/piq_focalnet.yaml, recipes/ESC50/interpret/hparams/piq_vit.yaml) => "ValueError: 'embedding_model_path' is a !PLACEHOLDER and must be replaced." Please, run them with: python -c 'from tests.utils.recipe_tests import run_recipe_tests; print("TEST FAILED!") if not(run_recipe_tests(filters_fields=["Dataset"], filters=[["ESC50"]], do_checks=True, run_opts="--device=cuda")) else print("TEST PASSED")'
Please, share the models with me such that I can upload them on the official dropbox.
Just like the other methods, I recommend putting the model on HF as well. This way, users can directly run the interpretation script (nterpret_amt.py) before training the classifier.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addressed the comments from #2388.