Tentative fix for Windows --editable installs#2541
Merged
Adel-Moumen merged 1 commit intoJun 6, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes(?) the issue mentioned in the last comment of #2536. On Windows, the default is not UTF-8, so some users are facing issues when using
--editableinstalls. Regular wheel installs would not reproduce the problem since those do not runsetup.py.There might still be problematic
open()s so perhaps all of them should explicitly useencoding="utf-8"someday.Before submitting
PR review
Reviewer checklist