Skip to content

Update common_voice_prepare.py#2557

Merged
asumagic merged 1 commit into
developfrom
FIX-cv-convert-mp3
May 30, 2024
Merged

Update common_voice_prepare.py#2557
asumagic merged 1 commit into
developfrom
FIX-cv-convert-mp3

Conversation

@Adel-Moumen

Copy link
Copy Markdown
Collaborator

What does this PR do?

This PR fix an issue where CV recipe is converting twice mp3 to wav format.

Before submitting
  • Did you read the contributor guideline?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Does your code adhere to project-specific code style and conventions?

PR review

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified
  • Confirm that the changes adhere to compatibility requirements (e.g., Python version, platform)
  • Review the self-review checklist to ensure the code is ready for review

@Adel-Moumen Adel-Moumen requested a review from asumagic May 30, 2024 11:47
@Adel-Moumen Adel-Moumen self-assigned this May 30, 2024
@Adel-Moumen Adel-Moumen added the bug Something isn't working label May 30, 2024
@asumagic asumagic merged commit cd86624 into develop May 30, 2024
@asumagic asumagic deleted the FIX-cv-convert-mp3 branch May 30, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants