Turn huggingface updates off by default to fix #2817#2832
Merged
TParcollet merged 1 commit intoFeb 25, 2025
Conversation
Collaborator
Author
|
The other thing that causes this issue is that the fetch parameters passed to |
TParcollet
approved these changes
Feb 25, 2025
TParcollet
left a comment
Collaborator
There was a problem hiding this comment.
This makes sense to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2817
When the files exist locally, we don't want to hit the network unless specifically requested to. When this option is
True, thenfetchstill downloads the model to the cache, even if it exists in the target directory, in case there's some update to the model.This option is not yet made available through
Pretrained.from_hparamsbut would be accessible if and when we merge #2828.