Skip to content

Dselans/graceful-exit - #24

Merged
dselans merged 2 commits into
mainfrom
dselans/no-looper
Jun 25, 2024
Merged

Dselans/graceful-exit#24
dselans merged 2 commits into
mainfrom
dselans/no-looper

Conversation

@dselans

@dselans dselans commented Jun 25, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor
  1. Remove looper to avoid races where Consume is ran in multiple goroutines. Full fix (without removing looper) would mean to create a map of loopers per Consume() but that's a decent chunk of work.
  2. Update Stop() to wait for Consume()'s to exit (using a waitgroup) + optional timeout

@dselans dselans changed the title Dselans/no looper Dselans/graceful-exit Jun 25, 2024
@dselans
dselans merged commit db1dcea into main Jun 25, 2024
@dselans
dselans deleted the dselans/no-looper branch June 25, 2024 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@dselans