Skip to content

Minor fixes on update connections #1640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jacalata merged 13 commits into from
Jul 25, 2025
Merged

Minor fixes on update connections #1640

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
88985fe
Updated TSC with new API's
vchavatapalli Jul 15, 2025
746b345
chore: refactor XML payload into RequestFactory
jorwoods Jul 20, 2025
75f5f4c
style: black samples
jorwoods Jul 20, 2025
8ee48d1
Merge pull request #1 from jorwoods/jorwoods/conns_req_fact
vchavatapalli Jul 21, 2025
1fb57d5
Updated token name, value
vchavatapalli Jul 21, 2025
9c2bec3
Clean up
vchavatapalli Jul 21, 2025
a40d774
Added response parsing
vchavatapalli Jul 21, 2025
b407590
Fixed issues
vchavatapalli Jul 21, 2025
dc92d17
Minor fixes to request payloads
vchavatapalli Jul 22, 2025
1add816
merge with dev branch
vchavatapalli Jul 23, 2025
a75bb40
Added assertions for test cases
vchavatapalli Jul 23, 2025
9a1c675
style fix
vchavatapalli Jul 23, 2025
b90473d
Fixed the login method
vchavatapalli Jul 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Minor fixes to request payloads
  • Loading branch information
@vchavatapalli
vchavatapalli committed Jul 22, 2025
commit dc92d17682f2a8291bd7fcef683e1863789f932f
2 changes: 1 addition & 1 deletion samples/update_connection_auth.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ def main():
connection = connections[0]
connection.username = args.datasource_username
connection.password = args.datasource_password
connection.authentication_type = args.authentication_type
connection.auth_type = args.authentication_type
connection.embed_password = True

updated_connection = update_function(resource, connection)
Expand Down
2 changes: 2 additions & 0 deletions tableauserverclient/server/request_factory.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1162,6 +1162,8 @@ def update_req(self, xml_request: ET.Element, connection_item: "ConnectionItem")
connection_element.attrib["userName"] = connection_item.username
if connection_item.password is not None:
connection_element.attrib["password"] = connection_item.password
if connection_item.auth_type is not None:
connection_element.attrib["authenticationType"] = connection_item.auth_type
if connection_item.embed_password is not None:
connection_element.attrib["embedPassword"] = str(connection_item.embed_password).lower()
if connection_item.query_tagging is not None:
Expand Down