Skip to content

PHP code sniffer - #4

Merged
Firtzberg merged 1 commit into
thecodingmachine:2.0from
Firtzberg:code-sniffer
Apr 15, 2020
Merged

PHP code sniffer#4
Firtzberg merged 1 commit into
thecodingmachine:2.0from
Firtzberg:code-sniffer

Conversation

@Firtzberg

Copy link
Copy Markdown
Collaborator

Added spell checker (PHP code sniffer) and complying with PSR-2.

@Firtzberg

Copy link
Copy Markdown
Collaborator Author

After the two PRs get merged please make a new release with the major version being 2.

@Firtzberg

Copy link
Copy Markdown
Collaborator Author

@moufmouf Where are we with this?
I need this for a package which I developed.

@Firtzberg

Copy link
Copy Markdown
Collaborator Author

@moufmouf
Sorry to be a pain in the ass. I would like this merged and released so that I can use it in another package.
If it doesn't happen within this week I intend to release this package under my own name.
I hope that's fine with you.

@moufmouf

Copy link
Copy Markdown
Member

Hey @Fritzberg,

I'm sorry, I completely missed your last 2 PRs.

You know what? You probably have invested more time in this project than I have and you definitely seem to know what you are doing. I have a ton of other projects to manage so I keep missing your notifications.

I'll add you as a maintainer on this repository. Simply notify me when you are doing changes and if you don't hear for me in the coming days, assume I'm ok :D

@Firtzberg
Firtzberg merged commit b030cdd into thecodingmachine:2.0 Apr 15, 2020
@Firtzberg
Firtzberg deleted the code-sniffer branch April 18, 2020 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants