fix: throw NonZeroExitError when process is killed by signal - #146
Merged
Conversation
naveentehrpariya
force-pushed
the
fix-throw-on-signal-kill
branch
from
June 29, 2026 07:18
e911f26 to
a0be64d
Compare
43081j
force-pushed
the
fix-throw-on-signal-kill
branch
2 times, most recently
from
July 1, 2026 11:29
3402520 to
ed0208c
Compare
43081j
force-pushed
the
fix-throw-on-signal-kill
branch
from
July 1, 2026 11:32
ed0208c to
8ce8f2b
Compare
43081j
approved these changes
Jul 1, 2026
5 tasks
This was referenced Aug 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When a child process is killed by a signal (SIGABRT, SIGKILL, SIGTERM, etc.),
throwOnError: truesilently resolves instead of throwingNonZeroExitError.Root cause: When a process dies by signal, Node.js sets
child.exitCode = nullandchild.signalCodeto the signal name. TheexitCodegetter returnsundefinedfornull, and thethrowOnErrorcheck excludesundefined— so signal-killed processes slip through. Same flaw exists inxSync.Changes
signalCodetoCommonOutputApiinterface andExecProcessgetterthrowOnErrorin_waitForOutputand async iterator to throw whensignalCode != nullxSyncthrowOnError to also checksignalCodeNonZeroExitErrormessage to"Process was killed with signal SIGTERM"for signal deaths; exposesignalCodegetterFixes #144