Dev phi issue - problem with min & max phi calculation when crossing +pi/-pi line.#161
Merged
Conversation
Update fork from official version - dev branch
Update fork from official version - dev branch
Updating Dev from official Dev
…hecking the hit at the +pi,-pi border
Updating Dev from official Dev
…ed returns always true
Contributor
Author
|
Kindly tested by Gabrielle using the baseline geometry -> OK: Compare with the older version: |
alkemyst
added a commit
that referenced
this pull request
Jan 25, 2016
Dev phi issue - problem with min & max phi calculation when crossing +pi/-pi line.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented new algorithm to find if the module was possibly hit to speed-up the whole procedure of tracking algorithm. The couldHit function works correctly only for the rectangular modules, so for wedge-shaped modules it returns always true (correct, but no speed-up effect).