Merge PR#332 from Zbynek: renaming HitNew -> Hit, TrackNew -> Track#409
Merged
Conversation
* Added missing functionality from hit class to TrackNew & HitNew classes. * Namely, added HitPassiveType which may be of BeamPipe, Service, Support or IP -> necessary for inactive hits in Hit class. * Additionally, added tracking volumes variables to Hit class. * Finally, Analyzer code adjusted to new smart pointer policy used in TrackNew class & HitNew class. * HitNew & TrackNew classes then renamed to regular Track & Hit classes. hit.cpp & hit.hh completely removed.
Pico PR : removed HitNew and TrackNew classes from Makefile
…e in the case of an inactive element crossing the Z=0 plane. 1) Should take the negative value of eta on the left side, otherwise comparisions with track eta does not make any sense!!! 2) Should be innerRadius + rWidth instead of innerRadius. Fortunately, was unused since all inactive surfaces are cut in 2 by the Z=0 plane.
…only for tracks coming from 0 until now).
…ctive element, one should not select the Z > 0 volumes only (assuming eta >= 0). Indeed, the IP can be at Z < 0, hence volumes on (-Z) side can be hit.
…unt in track length section calculation!
…red along a track!.
…ement::checkTrackHits has the following issues in devLite: some hits positions are wrongly computed and are actually not inside the inactive volume, hugely increasing the total crossed MB (and hence worsening the resolution). + Case of a tube or disk crossed in the non-trivial sense not always taken into account. Created new and fully debugged InactiveElement::checkTrackHits method (should be backported to devLitegit log).
…s region is a gaussian Gaus(0, 70). Though, the code was only taking into consideration the sensors such that sensor.maxZ() > 0.
…gion from -70 mm to 70 mm.
… Still addEfficiency issue to solve.
…) : now compiles :)
…, because the local resolution is assigned to it. It cannot be stored directly within the track, since a given module will be hit by several tracks, and we want the information at the module level!
…s) plot in OT material tab: was showing OT + IT result instead of OT result only. This is not really an issue in itself, but since there is a OT, IT, and Total material tabs, things should follow that logic.
Contributor
Author
|
IMPORTANT NB:
Each time I create a new PR, I keep the previous commits from previous PRs, so that all previous changes and fixes are incorporated, and so that there will be no merging conflict. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the merge of #332 .
All regressions corrected :)
All merging conflicts solved :)
This PR is improving style, there is no effect on the results.
Before PR:
http://ghugo.web.cern.ch/ghugo/layouts/test/OT613_200_IT404_patternreco_70luminous_triggerfixedDistance/info.html
After PR:
http://ghugo.web.cern.ch/ghugo/layouts/test/OT613_200_IT404_merge/info.html