Skip to content

Merge PR#332 from Zbynek: renaming HitNew -> Hit, TrackNew -> Track#409

Merged
alkemyst merged 26 commits into
tkLayout:dev_gabiefrom
ghugo83:merge
Dec 8, 2017
Merged

Merge PR#332 from Zbynek: renaming HitNew -> Hit, TrackNew -> Track#409
alkemyst merged 26 commits into
tkLayout:dev_gabiefrom
ghugo83:merge

Conversation

@ghugo83

@ghugo83 ghugo83 commented Dec 1, 2017

Copy link
Copy Markdown
Contributor

This is the merge of #332 .
All regressions corrected :)
All merging conflicts solved :)

This PR is improving style, there is no effect on the results.

Before PR:
http://ghugo.web.cern.ch/ghugo/layouts/test/OT613_200_IT404_patternreco_70luminous_triggerfixedDistance/info.html

After PR:
http://ghugo.web.cern.ch/ghugo/layouts/test/OT613_200_IT404_merge/info.html

drasal and others added 26 commits March 23, 2017 19:10
* Added missing functionality from hit class to TrackNew & HitNew classes.
* Namely, added HitPassiveType which may be of BeamPipe, Service, Support or IP -> necessary for inactive hits in Hit class.
* Additionally, added tracking volumes variables to Hit class.
* Finally, Analyzer code adjusted to new smart pointer policy used in TrackNew class & HitNew class.
* HitNew & TrackNew classes then renamed to regular Track & Hit classes. hit.cpp & hit.hh completely removed.
Pico PR : removed HitNew and TrackNew classes from Makefile
…e in the case of an inactive element crossing the Z=0 plane. 1) Should take the negative value of eta on the left side, otherwise comparisions with track eta does not make any sense!!! 2) Should be innerRadius + rWidth instead of innerRadius. Fortunately, was unused since all inactive surfaces are cut in 2 by the Z=0 plane.
…ctive element, one should not select the Z > 0 volumes only (assuming eta >= 0). Indeed, the IP can be at Z < 0, hence volumes on (-Z) side can be hit.
…ement::checkTrackHits has the following issues in devLite: some hits positions are wrongly computed and are actually not inside the inactive volume, hugely increasing the total crossed MB (and hence worsening the resolution). + Case of a tube or disk crossed in the non-trivial sense not always taken into account. Created new and fully debugged InactiveElement::checkTrackHits method (should be backported to devLitegit log).
…s region is a gaussian Gaus(0, 70). Though, the code was only taking into consideration the sensors such that sensor.maxZ() > 0.
…, because the local resolution is assigned to it. It cannot be stored directly within the track, since a given module will be hit by several tracks, and we want the information at the module level!
…s) plot in OT material tab: was showing OT + IT result instead of OT result only. This is not really an issue in itself, but since there is a OT, IT, and Total material tabs, things should follow that logic.
@ghugo83

ghugo83 commented Dec 1, 2017

Copy link
Copy Markdown
Contributor Author

IMPORTANT NB:
The PRs to dev_gabie should be merged in the chronological order:

Each time I create a new PR, I keep the previous commits from previous PRs, so that all previous changes and fixes are incorporated, and so that there will be no merging conflict.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants