feat: tmuxinator/teamocil feature parity (recut)#1046
Open
tony wants to merge 1 commit into
Open
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #1046 +/- ##
==========================================
+ Coverage 82.56% 84.37% +1.81%
==========================================
Files 31 35 +4
Lines 2770 3347 +577
Branches 518 663 +145
==========================================
+ Hits 2287 2824 +537
- Misses 346 361 +15
- Partials 137 162 +25 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
dfaac96 to
4e9116c
Compare
d294b1c to
8c05c5d
Compare
why: tmuxp lacked several tmuxinator and teamocil workflows, so configs
from those tools lost behavior on import and users missed the lifecycle
and session-management commands they relied on.
what:
- Add session lifecycle commands: tmuxp stop / new / copy / delete.
- Add project lifecycle hooks: on_project_start / restart / exit / stop.
- Add {{ variable }} config templating, filled via --set at load time.
- Add pane titles and window keys (synchronize, shell_command_after,
clear).
- Add tmuxp load flags: --here, --no-shell-command-before, --debug.
- Broaden tmuxinator/teamocil imports: hooks, named panes, startup
focus, synchronized windows, tmux CLI args, teamocil v1.x format.
- Extend the builder protocol build() with here= for current-window
loads so all builders share the contract.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is a replacement recut for #1025. It keeps the parity work in three reviewable commits:
Closes #1031.
Review Fixes Folded In
tmuxp load --here.shell_command_afterbefore synchronized panes are enabled.tmuxp deletetargets before unlinking files.--hereoutside tmux before existing-session handling.configfallback paths beforeServercreation, including./tmux.confrelative to the workspace file and~/tmux.confviaHOME.Parity Check
The final tree matches the original
paritybranch except for the intentional workspace config path-expansion fix and its regression coverage:src/tmuxp/cli/load.pytests/cli/test_load.pyVerification
Run before each commit and again at branch tip:
$ unset NO_COLOR; rm -rf docs/_build; uv run ruff check . --fix --show-fixes; uv run ruff format .; uv run mypy .; uv run py.test --reruns 0 -vvv; just build-docs;Final branch-tip results:
uv run ruff check . --fix --show-fixes: all checks passeduv run ruff format .: 144 files left unchangeduv run mypy .: success, no issues in 144 source filesuv run py.test --reruns 0 -vvv: 1038 passed, 2 skippedjust build-docs: build succeeded with 76 existing warningsNO_COLORwas unset for the gates because this local shell exportsNO_COLOR=1, while existing color tests assert ANSI output in forced-color cases.