Skip to content

Fix start_directory not being respected in first pane#787

Merged
tony merged 2 commits into
tmux-python:masterfrom
nvasilas:master
Aug 5, 2022
Merged

Fix start_directory not being respected in first pane#787
tony merged 2 commits into
tmux-python:masterfrom
nvasilas:master

Conversation

@nvasilas

Copy link
Copy Markdown
Contributor

Respect start_directory for first pane.

@CLAassistant

CLAassistant commented Jul 31, 2022

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@codecov

codecov Bot commented Jul 31, 2022

Copy link
Copy Markdown

Codecov Report

Merging #787 (290b355) into master (0110237) will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #787      +/-   ##
==========================================
+ Coverage   75.59%   75.65%   +0.05%     
==========================================
  Files          16       16              
  Lines        1254     1257       +3     
  Branches      322      323       +1     
==========================================
+ Hits          948      951       +3     
  Misses        220      220              
  Partials       86       86              
Impacted Files Coverage Δ
tmuxp/workspacebuilder.py 85.29% <100.00%> (+0.21%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@tony

tony commented Jul 31, 2022

Copy link
Copy Markdown
Member

@nvasilas Can you sign the CLA?

@tony tony self-requested a review July 31, 2022 14:25
@tony

tony commented Jul 31, 2022

Copy link
Copy Markdown
Member

@nvasilas Is it possible you could write a test?

@nvasilas

Copy link
Copy Markdown
Contributor Author

@tony Sure you will receive a pull request for a test soon.

@tony

tony commented Jul 31, 2022

Copy link
Copy Markdown
Member

@nvasilas Sounds good!

https://tmuxp.git-pull.com/developing.html may be helpful

@tony

tony commented Jul 31, 2022

Copy link
Copy Markdown
Member

@nvasilas P.S. You may also want to rebase against master and update to the latest packages.

@tony tony linked an issue Aug 1, 2022 that may be closed by this pull request
@tony tony changed the title Fixes #724 Fix start_directory not being respected in first pane Aug 5, 2022
@tony tony merged commit b5bdd5b into tmux-python:master Aug 5, 2022
tony added a commit that referenced this pull request Aug 5, 2022
tony added a commit that referenced this pull request Aug 5, 2022
@tony

tony commented Aug 5, 2022

Copy link
Copy Markdown
Member

@nvasilas Thank you! Merged and live in v1.12.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: start_directory isn't respected for first pane

3 participants