Restore #6202: Move preact from dependencies into peerDependencies#6341
Restore #6202: Move preact from dependencies into peerDependencies#6341qxprakash wants to merge 3 commits into
Conversation
🦋 Changeset detectedLatest commit: a3d39fa The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 07db03e8d2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "vitest": "^3.2.4" | ||
| }, | ||
| "peerDependencies": { | ||
| "preact": "^10.26.10" |
There was a problem hiding this comment.
When a user installs a package that depends on @uppy/utils but was not updated, for example @uppy/aws-s3 imports runtime values from @uppy/utils while its manifest still has no preact dependency or peer, Yarn PnP/strict peer resolution leaves @uppy/utils without a provider for this new peer. Importing @uppy/utils also follows the VirtualList re-export that imports preact/hooks, so those non-UI packages can fail at install/runtime after this change. Either keep preact as a dependency here or propagate a preact peer/dependency to the published dependents.
Useful? React with 👍 / 👎.
restore #6202 to 07db03e