Use persistent connections to avoid factory resets - #25
Merged
Conversation
unaiur
force-pushed
the
persistent-v2
branch
3 times, most recently
from
January 24, 2021 01:19
fcb31c6 to
41d4e34
Compare
Refactor connection handling to use persistent connections and reduce the chance of hitting a known bug in the Max! Cube that resets to factory setting once every 50,000 connections. Issues fixed: - uebelack#12 - [Unable to change back to scheduled temperature (auto mode)](uebelack#24 Breaking changes: - Increased minimum supported version of Python to >= 3.7 - MaxCubeConnection object removed. MaxCube constructor now receives the host and port parameters directly - The connection is not released after each command is send. This can block other applications to connect to the Max! Cube. You can call cube disconnect() method to release the connection manually.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Refactor connection handling to use persistent connections and
reduce the chance of hitting a known bug in the Max! Cube that
resets to factory setting once every 50,000 connections.
Issues fixed:
Breaking changes: