Skip to content

Performance Improvements #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cmcnicholas wants to merge 9 commits into
base: master
Choose a base branch
from
+48 −32
Open

Performance Improvements #127

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
1069522
feat: memoised prng checking
cmcnicholas Sep 13, 2025
4bcef82
feat: init Uint8Array once
cmcnicholas Sep 13, 2025
054b847
feat: array.join for concat
cmcnicholas Sep 13, 2025
5eb0cfb
feat: typeof checks and collapse error checking
cmcnicholas Sep 13, 2025
66ba2a0
chore: modern substring usage
cmcnicholas Sep 13, 2025
093dde5
feat: access string by array index not charAt
cmcnicholas Sep 13, 2025
26c40d5
fix: incorrect order
cmcnicholas Sep 13, 2025
ba16c21
feat: substitute indexOf for prebuilt lookup
cmcnicholas Sep 13, 2025
5f16859
chore: don't use coalescing operator
cmcnicholas Sep 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
feat: array.join for concat
  • Loading branch information
@cmcnicholas
cmcnicholas committed Sep 13, 2025
commit 054b847994d942f2823aba7577fbcae63e952dcd
8 changes: 8 additions & 0 deletions source/ulid.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,8 +94,12 @@ export function encodeRandom(len: number, prng: PRNG): string {
let str = "";
for (; len > 0; len--) {
str = randomChar(prng) + str;
const str = new Array(len);
for (let currentLen = len; currentLen > 0; currentLen--) {
str[len - currentLen] = randomChar(prng);
}
return str;
return str.join("");
}

/**
Expand Down Expand Up @@ -125,12 +129,16 @@ export function encodeTime(now: number, len: number = TIME_LEN): string {
}
let mod: number,
str: string = "";
let mod: number;
const str = new Array(len);
for (let currentLen = len; currentLen > 0; currentLen--) {
mod = now % ENCODING_LEN;
str = ENCODING.charAt(mod) + str;
str[len - currentLen] = ENCODING[mod];
now = (now - mod) / ENCODING_LEN;
}
return str;
return str.join("");
}

function inWebWorker(): boolean {
Expand Down