Skip to content

fix(ci): support Node 24 releases and fork previews - #48

Merged
ivoIturrieta merged 2 commits into
mainfrom
fix/ci-release-and-fork-previews
Jul 15, 2026
Merged

fix(ci): support Node 24 releases and fork previews#48
ivoIturrieta merged 2 commits into
mainfrom
fix/ci-release-and-fork-previews

Conversation

@ivoIturrieta

@ivoIturrieta ivoIturrieta commented Jul 15, 2026

Copy link
Copy Markdown
Collaborator

Summary

What does this PR do? Keep it brief.

Changes

Test Plan

  • pnpm build passes
  • pnpm test passes
  • Tested in Storybook (if UI change)
  • Added/updated tests for new behavior

Notes

Any additional context for reviewers.


📖 Storybook Preview: https://unlayer.github.io/elements/pr/48/

Copilot AI review requested due to automatic review settings July 15, 2026 17:56

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the repository’s GitHub Actions workflows to run on Node.js 24 and refactors Storybook PR previews to work safely for forked pull requests by publishing a built artifact via a trusted workflow_run deployment workflow.

Changes:

  • Bump workflow Node.js versions from 20 → 24 (publish + Storybook deploy workflows).
  • Change release workflow to install a specific npm major (npm@12) for trusted publishing.
  • Replace direct PR preview deployment with an artifact-based flow plus a new trusted workflow_run preview deployment workflow (supports forks).

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
.github/workflows/publish.yml Updates release/publish pipeline to Node 24 and pins npm version used for trusted publishing.
.github/workflows/deploy-storybook.yml Updates Storybook build workflow to Node 24 and switches PR previews to artifact upload (no direct PR deploy).
.github/workflows/deploy-storybook-preview.yml Adds trusted workflow_run workflow to deploy PR preview from uploaded artifact and update PR description.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/deploy-storybook.yml Outdated
@codecov

codecov Bot commented Jul 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.50%. Comparing base (ac7140a) to head (d42ba61).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #48   +/-   ##
=======================================
  Coverage   95.50%   95.50%           
=======================================
  Files          31       31           
  Lines        1937     1937           
  Branches      382      382           
=======================================
  Hits         1850     1850           
  Misses         86       86           
  Partials        1        1           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ivoIturrieta
ivoIturrieta merged commit adaa68c into main Jul 15, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants