Skip to content

fix: respect useDefineForClassFields=false setting#156

Merged
hannoeru merged 3 commits into
unplugin:mainfrom
orgads:use-define-false
Apr 22, 2025
Merged

fix: respect useDefineForClassFields=false setting#156
hannoeru merged 3 commits into
unplugin:mainfrom
orgads:use-define-false

Conversation

@orgads

@orgads orgads commented Apr 7, 2025

Copy link
Copy Markdown
Contributor

Description

This setting defaults to true, so if not explicitly set to false, it is not propagated to the transformer.

Linked Issues

vitest-dev/vitest#7805

@bolt-new-by-stackblitz

Copy link
Copy Markdown

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@orgads orgads force-pushed the use-define-false branch from 5935f44 to dd97210 Compare April 7, 2025 14:50
@orgads orgads changed the title Respect useDefineForClassFields=false setting fix: respect useDefineForClassFields=false setting Apr 7, 2025
@orgads orgads force-pushed the use-define-false branch from dd97210 to 44e2a38 Compare April 7, 2025 14:58
@orgads

orgads commented Apr 16, 2025

Copy link
Copy Markdown
Contributor Author

@hannoeru ping

Comment thread src/index.ts Outdated
This setting defaults to true, so if not explicitly set to false, it
is not propagated to the transformer.

See vitest-dev/vitest#7805
@orgads orgads force-pushed the use-define-false branch from 44e2a38 to 463978d Compare April 16, 2025 09:34
@orgads

orgads commented Apr 22, 2025

Copy link
Copy Markdown
Contributor Author

@hannoeru Anything else?

@hannoeru hannoeru merged commit db919e3 into unplugin:main Apr 22, 2025
@orgads orgads deleted the use-define-false branch April 22, 2025 06:06
@orgads

orgads commented Apr 22, 2025

Copy link
Copy Markdown
Contributor Author

Thank you.

@github-actions

Copy link
Copy Markdown

🎉 This PR is included in version 1.5.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants