fix(types): apply AppType's generic parameter to props, not pageProps - #97202
Open
gee-46 wants to merge 1 commit into
Open
fix(types): apply AppType's generic parameter to props, not pageProps#97202gee-46 wants to merge 1 commit into
gee-46 wants to merge 1 commit into
Conversation
Fixes vercel#42846 What: AppType<P>'s generic parameter P was substituted into the pageProps slot of the component's props instead of being merged onto the top-level props. Why: Custom fields returned alongside pageProps from a custom App.getInitialProps weren't reflected correctly — real top-level props threw false type errors, and nonexistent pageProps fields showed no error. Repro: https://codesandbox.io/s/polished-tree-xhvisb How: Changed the third generic argument from AppPropsType<any, P> to P & AppPropsType<any, any> so P merges directly onto the component's props.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #42846
What: AppType
's generic parameter P was substituted into the pageProps slot of the component's props instead of being merged onto the top-level props.
Why: Custom fields returned alongside pageProps from a custom App.getInitialProps weren't reflected correctly — real top-level props threw false type errors, and nonexistent pageProps fields showed no error. Repro: https://codesandbox.io/s/polished-tree-xhvisb
How: Changed the third generic argument from AppPropsType<any, P> to P & AppPropsType<any, any> so P merges directly onto the component's props.