Skip to content

refactor: clean up branching and CC/non-CC code in connection() - #97210

Draft
lubieowoce wants to merge 1 commit into
canaryfrom
lubieowoce/refactor-connection
Draft

refactor: clean up branching and CC/non-CC code in connection()#97210
lubieowoce wants to merge 1 commit into
canaryfrom
lubieowoce/refactor-connection

Conversation

@lubieowoce

@lubieowoce lubieowoce commented Aug 11, 2026

Copy link
Copy Markdown
Member

Simplifies the branching in connection() and isolates parts that don't run in cacheComponents.

  • workStore and workUnitStore check can be an early return, `conneciton()`` is useless without them anyway
  • asyncApiPromises check is the same in dev and prod
  • export const dynamic = ... and trackDynamicDataInDynamicRender only runs if cacheComponents is off.

Stack created with GitHub Stacks CLI • Give Feedback 💬

@github-actions

github-actions Bot commented Aug 11, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Failing test suites

Commit: 3e3eaba | About building and testing Next.js

pnpm test-dev test/development/app-dir/use-cache-custom-handler-dev/use-cache-custom-handler-dev.test.ts (job)

  • use-cache-custom-handler-dev > serves a short-expire value warm through a custom handler and re-warms it on each reload (DD)
  • use-cache-custom-handler-dev > stops serving a front-cached entry after the backing cache is purged out-of-band (DD)
Expand output

● use-cache-custom-handler-dev › serves a short-expire value warm through a custom handler and re-warms it on each reload

expect(received).not.toBe(expected) // Object.is equality

Expected: not "2026-08-11T23:20:40.181Z"

  69 |     await retry(async () => {
  70 |       await browser.refresh()
> 71 |       expect(await browser.elementById('value').text()).not.toBe(coldValue)
     |                                                             ^
  72 |     })
  73 |   })
  74 |

  at toBe (development/app-dir/use-cache-custom-handler-dev/use-cache-custom-handler-dev.test.ts:71:61)
  at retry (lib/next-test-utils.ts:868:14)
  at Object.<anonymous> (development/app-dir/use-cache-custom-handler-dev/use-cache-custom-handler-dev.test.ts:69:5)

● use-cache-custom-handler-dev › stops serving a front-cached entry after the backing cache is purged out-of-band

expect(received).not.toBe(expected) // Object.is equality

Expected: not "2026-08-11T23:20:48.011Z"

   96 |     await retry(async () => {
   97 |       await browser.refresh()
>  98 |       expect(await browser.elementById('value').text()).not.toBe(coldValue)
      |                                                             ^
   99 |     })
  100 |   })
  101 | })

  at toBe (development/app-dir/use-cache-custom-handler-dev/use-cache-custom-handler-dev.test.ts:98:61)
  at retry (lib/next-test-utils.ts:868:14)
  at Object.<anonymous> (development/app-dir/use-cache-custom-handler-dev/use-cache-custom-handler-dev.test.ts:96:5)

Other failing CI jobs

@github-actions

github-actions Bot commented Aug 11, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Stats from current PR

🔴 2 regressions

Metric Canary PR Change Trend
Webpack Build Time (cached) 24.550s 25.296s 🔴 +746ms (+3%) █▂▁▁▁
Webpack Cold (First Request) 3.340s 3.520s 🔴 +180ms (+5%) █▂▂▁▁
📊 All Metrics
📖 Metrics Glossary

Dev Server Metrics:

  • Listen = TCP port starts accepting connections
  • First Request = HTTP server returns successful response
  • Cold = Fresh build (no cache)
  • Warm = With cached build artifacts

Build Metrics:

  • Fresh = Clean build (no .next directory)
  • Cached = With existing .next directory

Change Thresholds:

  • Time: Changes < 50ms AND < 10%, OR < 2% are insignificant
  • Size: Changes < 1KB AND < 1% are insignificant
  • All other changes are flagged to catch regressions

⚡ Dev Server

Metric Canary PR Change Trend
Cold (Listen) 814ms 815ms ✓ ▅▅▁▄▅
Cold (Ready in log) 809ms 809ms ✓ ▃▄▁▄▅
Cold (First Request) 1.369s 1.373s ✓ ▂▄▁▄▅
Warm (Listen) 862ms 813ms ✓ ▄▅▁▅▅
Warm (Ready in log) 823ms 816ms ✓ ▂▅▁█▄
Warm (First Request) 1.371s 1.368s ✓ ▁▅▂█▄
📦 Dev Server (Webpack) (Legacy)

📦 Dev Server (Webpack)

Metric Canary PR Change Trend
Cold (Listen) 813ms 813ms ✓ █▁▁▁▁
Cold (Ready in log) 782ms 804ms ✓ █▂▁▁▁
Cold (First Request) 3.340s 3.520s 🔴 +180ms (+5%) █▂▂▁▁
Warm (Listen) 813ms 813ms ✓ █▂▂▂▂
Warm (Ready in log) 788ms 796ms ✓ █▂▂▁▁
Warm (First Request) 3.396s 3.463s ✓ █▂▂▁▁

⚡ Production Builds

Metric Canary PR Change Trend
Fresh Build 6.375s 6.409s ✓ ▁▃▁▃▄
Cached Build 3.281s 3.271s ✓ ▂▂▁▆▆
📦 Production Builds (Webpack) (Legacy)

📦 Production Builds (Webpack)

Metric Canary PR Change Trend
Fresh Build 24.266s 24.323s ✓ █▂▁▁▁
Cached Build 24.550s 25.296s 🔴 +746ms (+3%) █▂▁▁▁
node_modules Size 553 MB 553 MB ✓ ▁▁▁▁▁
📦 Bundle Sizes

Bundle Sizes

⚡ Turbopack

Client

Main Bundles
Canary PR Change
00hz9bp6px29t.js gzip 162 B N/A -
02n-1c_6-_z6p.js gzip 161 B N/A -
050icza-xjz0i.js gzip 5.73 kB N/A -
07jdby0ue616s.js gzip 450 B N/A -
0bjdc8muo74n5.js gzip 8.71 kB N/A -
0cz1d0mv5g_q7.js gzip 39.4 kB 39.4 kB ✓
0jrl8kox2uf45.js gzip 157 B N/A -
0nhmtnlj8hr6m.js gzip 158 B N/A -
0q36apx7b1q_e.js gzip 7.54 kB N/A -
0rci1f3or1a19.js gzip 13.3 kB N/A -
0sasp2uaf4ye5.js gzip 169 B N/A -
1_2x714--ii1i.js gzip 8.76 kB N/A -
1-3y752pkth5-.js gzip 10 kB N/A -
1c7o26spjhd9d.js gzip 157 B N/A -
1elt1qium-r2m.css gzip 115 B 115 B ✓
1k6dd7su4cfei.js gzip 3.57 kB N/A -
1tf1phijqlx9j.js gzip 220 B 220 B ✓
1uzabyd1120a1.js gzip 8.71 kB N/A -
1xf4ba83xb-84.js gzip 158 B N/A -
2-ufv8lc-g7gg.js gzip 10.6 kB N/A -
21kmjy_10x14f.js gzip 8.81 kB N/A -
28dhc6t85q1_p.js gzip 8.78 kB N/A -
2f-ilvczue-tp.js gzip 9.46 kB N/A -
2f1u17u5c8iny.js gzip 8.79 kB N/A -
2gq4lz6qq2chp.js gzip 71.6 kB N/A -
2ikltg_8iegxw.js gzip 10.3 kB N/A -
2rlwpl-wmbug5.js gzip 159 B N/A -
2t_dpo8ddqq4x.js gzip 159 B N/A -
2vxi673cz1-t4.js gzip 8.79 kB N/A -
38-q43pzktqhs.js gzip 1.46 kB N/A -
3g_iitcj-4_gx.js gzip 157 B N/A -
3hztwd4v6tf3a.js gzip 65.6 kB N/A -
3kovaxbq70rv3.js gzip 156 B N/A -
3mrwxzed0ylgv.js gzip 13.1 kB N/A -
3nbojhxiy1qv_.js gzip 13.7 kB N/A -
3sc2kd974a_o4.js gzip 152 B N/A -
3tldxa0ocqpwa.js gzip 47 kB N/A -
41u5s3oe2-erp.js gzip 2.29 kB N/A -
42t9sinrl8nmb.js gzip 157 B N/A -
445s_9hf8o7ao.js gzip 8.76 kB N/A -
turbopack-1l..-5yv.js gzip 3.73 kB 3.73 kB ✓
0-6bcj16ji2wf.js gzip N/A 10.6 kB -
07ryk0jced-sc.js gzip N/A 8.78 kB -
0jwho9fkrb_t3.js gzip N/A 2.29 kB -
0nzvszqtjjcdv.js gzip N/A 155 B -
0roh390ijzxa5.js gzip N/A 8.75 kB -
0vex9w55ursqj.js gzip N/A 8.79 kB -
1_l19exhzl_h4.js gzip N/A 157 B -
17oe55cu76cd7.js gzip N/A 450 B -
1drww5xikb-c-.js gzip N/A 9.46 kB -
1dwjcsink-x9d.js gzip N/A 154 B -
1g60xde_dv17t.js gzip N/A 8.79 kB -
1shyvhno4_0tn.js gzip N/A 156 B -
1uzv47btzam64.js gzip N/A 5.73 kB -
1vy7n7wxv_rh5.js gzip N/A 8.81 kB -
2-0i7pl900-ou.js gzip N/A 8.71 kB -
2-kcbngm7ik7y.js gzip N/A 8.75 kB -
2-szwf6t9xq20.js gzip N/A 156 B -
29n7_9qs6pr33.js gzip N/A 47 kB -
29p5-xa4jmdhg.js gzip N/A 13.7 kB -
2lpk5_hknut8q.js gzip N/A 13.1 kB -
2o4cibp3awtbw.js gzip N/A 3.56 kB -
2q0rrh7fdtey-.js gzip N/A 157 B -
2tousq11u689-.js gzip N/A 161 B -
2ugc69z0t0ypz.js gzip N/A 1.46 kB -
2vn4-juoy27qc.js gzip N/A 65.6 kB -
2we2htu1n5wen.js gzip N/A 167 B -
2yq2jmanh6g9r.js gzip N/A 71.6 kB -
3-_0ow7671xjh.js gzip N/A 7.55 kB -
3622yd0n93ey1.js gzip N/A 156 B -
36dn8i-_3dnq5.js gzip N/A 10 kB -
37y_bgn93nr4z.js gzip N/A 156 B -
3aomptn8mfhl-.js gzip N/A 150 B -
3fljpmwcjxqhx.js gzip N/A 10.3 kB -
3gz44skqdlsrb.js gzip N/A 8.71 kB -
3wz8k38x902se.js gzip N/A 155 B -
3y9tus7kb5su0.js gzip N/A 13.3 kB -
42bwwsa14g3c7.js gzip N/A 156 B -
Total 401 kB 401 kB ✅ -15 B

Server

Middleware
Canary PR Change
middleware-b..fest.js gzip 1.06 kB 1.06 kB ✓
Total 1.06 kB 1.06 kB ✓
Build Details
Build Manifests
Canary PR Change
_buildManifest.js gzip 880 B 876 B ✓
Total 880 B 876 B ✅ -4 B
Build Cache
Canary PR Change
00000001.sst gzip 12.9 MB 12.6 MB 🟢 279 kB (-2%)
00000002.sst gzip 14.7 MB 14 MB 🟢 723 kB (-5%)
00000003.sst gzip 12.4 MB 14.3 MB 🔴 +1.84 MB (+15%)
00000004.sst gzip 15.1 MB 14.2 MB 🟢 892 kB (-6%)
00000005.sst gzip 2.8 MB 10.2 MB 🔴 +7.37 MB (+263%)
00000006.sst gzip 10.2 MB 2.8 MB 🟢 7.41 MB (-73%)
00000007.sst gzip 59 B 59 B ✓
00000008.meta gzip 298 kB 89 B 🟢 298 kB (-100%)
00000009.meta gzip 89 B 298 kB 🔴 +298 kB (+334530%)
00000010.meta gzip 298 kB 298 kB ✓
00000011.meta gzip 298 kB 298 kB ✓
00000012.sst gzip 52.2 kB 51.3 kB 🟢 902 B (-2%)
00000013.sst gzip 1.82 MB 1.78 MB 🟢 42.9 kB (-2%)
00000014.sst gzip 59 B 59 B ✓
00000015.meta gzip 116 B 116 B ✓
00000016.meta gzip 326 kB 326 kB ✓
00000017.meta gzip 406 kB 404 kB 🟢 2.24 kB (-1%)
00000018.sst gzip 53 kB 52 kB 🟢 976 B (-2%)
00000019.sst gzip 1.41 MB 1.38 MB 🟢 26.5 kB (-2%)
00000020.sst gzip 59 B 59 B ✓
00000021.meta gzip 116 B 116 B ✓
00000022.meta gzip 326 kB 326 kB ✓
00000023.meta gzip 372 kB 372 kB ✓
00000024.sst gzip 53.1 kB 52.1 kB 🟢 1.02 kB (-2%)
00000025.sst gzip 1.41 MB 1.38 MB 🟢 26.7 kB (-2%)
00000026.sst gzip 59 B 59 B ✓
00000027.meta gzip 116 B 116 B ✓
00000028.meta gzip 326 kB 326 kB ✓
00000029.meta gzip 372 kB 372 kB ✓
00000030.sst gzip 52.3 kB 51.3 kB 🟢 968 B (-2%)
00000031.sst gzip 1.41 MB 1.38 MB 🟢 26.5 kB (-2%)
00000032.sst gzip 59 B 59 B ✓
00000033.meta gzip 116 B 116 B ✓
00000034.meta gzip 326 kB 326 kB ✓
00000035.meta gzip 372 kB 372 kB ✓
00000036.sst gzip 52.9 kB 52 kB 🟢 842 B (-2%)
00000037.sst gzip 1.41 MB 1.38 MB 🟢 26.7 kB (-2%)
00000038.sst gzip 59 B 59 B ✓
00000039.meta gzip 116 B 116 B ✓
00000040.meta gzip 326 kB 326 kB ✓
00000041.meta gzip 372 kB 372 kB ✓
CURRENT gzip 24 B 24 B ✓
LOG gzip 670 B 664 B ✓
Total 80.2 MB 80 MB ✅ -249 kB

📦 Webpack

Client

Main Bundles
Canary PR Change
3322-HASH.js gzip 66.1 kB N/A -
4191.HASH.js gzip 169 B N/A -
7920-HASH.js gzip 4.67 kB N/A -
9784-HASH.js gzip 5.63 kB N/A -
b1ad9f4c-HASH.js gzip 63.2 kB N/A -
framework-HASH.js gzip 59.7 kB 59.7 kB ✓
main-app-HASH.js gzip 253 B 253 B ✓
main-HASH.js gzip 40.1 kB 40.1 kB ✓
webpack-HASH.js gzip 1.68 kB 1.68 kB ✓
3577.HASH.js gzip N/A 168 B -
578-HASH.js gzip N/A 66.8 kB -
8590-HASH.js gzip N/A 5.61 kB -
9750-HASH.js gzip N/A 4.68 kB -
a8984546-HASH.js gzip N/A 63.2 kB -
Total 242 kB 242 kB ⚠️ +630 B
Polyfills
Canary PR Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB ✓
Total 39.4 kB 39.4 kB ✓
Pages
Canary PR Change
_app-HASH.js gzip 194 B 193 B ✓
_error-HASH.js gzip 181 B 182 B ✓
css-HASH.js gzip 334 B 331 B ✓
dynamic-HASH.js gzip 1.81 kB 1.81 kB ✓
edge-ssr-HASH.js gzip 255 B 253 B ✓
head-HASH.js gzip 349 B 351 B ✓
hooks-HASH.js gzip 382 B 384 B ✓
image-HASH.js gzip 581 B 582 B ✓
index-HASH.js gzip 260 B 259 B ✓
link-HASH.js gzip 2.48 kB 2.48 kB ✓
routerDirect..HASH.js gzip 317 B 318 B ✓
script-HASH.js gzip 384 B 386 B ✓
withRouter-HASH.js gzip 316 B 315 B ✓
1afbb74e6ecf..834.css gzip 106 B 106 B ✓
Total 7.95 kB 7.96 kB ⚠️ +4 B

Server

Edge SSR
Canary PR Change
edge-ssr.js gzip 129 kB 128 kB ✓
page.js gzip 293 kB 294 kB ✓
Total 422 kB 422 kB ⚠️ +53 B
Middleware
Canary PR Change
middleware-b..fest.js gzip 617 B 616 B ✓
middleware-r..fest.js gzip 156 B 156 B ✓
middleware.js gzip 45.5 kB 45.2 kB ✓
edge-runtime..pack.js gzip 842 B 842 B ✓
Total 47.1 kB 46.8 kB ✅ -260 B
Build Details
Build Manifests
Canary PR Change
_buildManifest.js gzip 717 B 718 B ✓
Total 717 B 718 B ⚠️ +1 B
Build Cache
Canary PR Change
0.pack gzip 4.8 MB 4.79 MB 🟢 6.1 kB (0%)
index.pack gzip 122 kB 122 kB ✓
index.pack.old gzip 122 kB 121 kB ✓
Total 5.04 MB 5.04 MB ✅ -6.55 kB

🔄 Shared (bundler-independent)

Runtimes
Canary PR Change
app-page-exp...dev.js gzip 374 kB 374 kB ✓
app-page-exp..prod.js gzip 207 kB 207 kB ✓
app-page-tur...dev.js gzip 374 kB 374 kB ✓
app-page-tur..prod.js gzip 206 kB 206 kB ✓
app-page-tur...dev.js gzip 370 kB 370 kB ✓
app-page-tur..prod.js gzip 204 kB 204 kB ✓
app-page.run...dev.js gzip 371 kB 371 kB ✓
app-page.run..prod.js gzip 204 kB 204 kB ✓
app-route-ex...dev.js gzip 82.6 kB 82.6 kB ✓
app-route-ex..prod.js gzip 55.8 kB 55.8 kB ✓
app-route-tu...dev.js gzip 82.7 kB 82.7 kB ✓
app-route-tu..prod.js gzip 55.8 kB 55.8 kB ✓
app-route-tu...dev.js gzip 82.3 kB 82.3 kB ✓
app-route-tu..prod.js gzip 55.6 kB 55.6 kB ✓
app-route.ru...dev.js gzip 82.2 kB 82.2 kB ✓
app-route.ru..prod.js gzip 55.6 kB 55.6 kB ✓
dev-validati...dev.js gzip 134 kB 134 kB ✓
dev-validati...dev.js gzip 134 kB 134 kB ✓
dev-validati...dev.js gzip 131 kB 131 kB ✓
dev-validati...dev.js gzip 131 kB 131 kB ✓
dist_client_...dev.js gzip 324 B 324 B ✓
dist_client_...dev.js gzip 326 B 326 B ✓
dist_client_...dev.js gzip 318 B 318 B ✓
dist_client_...dev.js gzip 317 B 317 B ✓
pages-api-tu...dev.js gzip 46.1 kB 46.1 kB ✓
pages-api-tu..prod.js gzip 34.3 kB 34.3 kB ✓
pages-api.ru...dev.js gzip 46 kB 46 kB ✓
pages-api.ru..prod.js gzip 34.3 kB 34.3 kB ✓
pages-turbo....dev.js gzip 54.8 kB 54.8 kB ✓
pages-turbo...prod.js gzip 39.8 kB 39.8 kB ✓
pages.runtim...dev.js gzip 54.8 kB 54.8 kB ✓
pages.runtim..prod.js gzip 39.8 kB 39.8 kB ✓
server.runti..prod.js gzip 66.7 kB 66.7 kB ✓
use-cache-pr...dev.js gzip 72.3 kB 72.3 kB ✓
use-cache-pr...dev.js gzip 72.3 kB 72.3 kB ✓
use-cache-pr...dev.js gzip 70.6 kB 70.6 kB ✓
use-cache-pr...dev.js gzip 70.5 kB 70.5 kB ✓
Total 4.1 MB 4.1 MB ✅ -1 B
📎 Tarball URL 
https://vercel-packages.vercel.app/next/commits/3e3eaba071187f94f1c970adaf57ca52f6ebd91a/next

Commit: 3e3eaba

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@lubieowoce