Skip to content

Allow running ncc before pnpm build - #97234

Merged
eps1lon merged 1 commit into
canaryfrom
sebbie/ncc-msw-resolver-polyfill
Aug 12, 2026
Merged

Allow running ncc before pnpm build#97234
eps1lon merged 1 commit into
canaryfrom
sebbie/ncc-msw-resolver-polyfill

Conversation

@eps1lon

@eps1lon eps1lon commented Aug 12, 2026

Copy link
Copy Markdown
Member

Fixes

[17:03:12] ncc_mswjs_interceptors failed because [tsl] ERROR in /home/runner/work/next.js/next.js/packages/next/src/server/og/cache-image-response.ts(27,17)
      TS2307: Cannot find module 'next/dist/compiled/@vercel/og/index.node.js' or its corresponding type declarations.

-- https://github.com/vercel/next.js/actions/runs/31515393262/job/93859146712#step:8:723

Now we use externalize the Promise.withResolvers polyfill to allow running ncc before we built dist.

test plan

  • cd packages/next && rm -rf dist && pnpm taskr ncc_mswjs_interceptors

@github-actions

github-actions Bot commented Aug 12, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Tests Passed

Commit: daca98d

@github-actions

github-actions Bot commented Aug 12, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Stats from current PR

🔴 1 regression

Metric Canary PR Change Trend
Webpack Build Time (cached) 23.806s 24.714s 🔴 +908ms (+4%) ▁▁▁▁▂
📊 All Metrics
📖 Metrics Glossary

Dev Server Metrics:

  • Listen = TCP port starts accepting connections
  • First Request = HTTP server returns successful response
  • Cold = Fresh build (no cache)
  • Warm = With cached build artifacts

Build Metrics:

  • Fresh = Clean build (no .next directory)
  • Cached = With existing .next directory

Change Thresholds:

  • Time: Changes < 50ms AND < 10%, OR < 2% are insignificant
  • Size: Changes < 1KB AND < 1% are insignificant
  • All other changes are flagged to catch regressions

⚡ Dev Server

Metric Canary PR Change Trend
Cold (Listen) 813ms 812ms ✓ ██▁██
Cold (Ready in log) 776ms 778ms ✓ ▄▆▁█▄
Cold (First Request) 1.281s 1.286s ✓ ▃▄▁█▁
Warm (Listen) 813ms 812ms ✓ ██▁██
Warm (Ready in log) 777ms 784ms ✓ ▂▅▁▆▄
Warm (First Request) 1.256s 1.272s ✓ ▂▄▁▇▂
📦 Dev Server (Webpack) (Legacy)

📦 Dev Server (Webpack)

Metric Canary PR Change Trend
Cold (Listen) 763ms 813ms ✓ ▁▁▁▁▁
Cold (Ready in log) 766ms 785ms ✓ ▁▁▁▁▂
Cold (First Request) 3.304s 3.320s ✓ ▁▁▂▁▂
Warm (Listen) 762ms 812ms ✓ ▁▁▁▁▁
Warm (Ready in log) 765ms 778ms ✓ ▁▁▁▁▁
Warm (First Request) 3.284s 3.369s ✓ ▁▁▁▁▂

⚡ Production Builds

Metric Canary PR Change Trend
Fresh Build 5.762s 5.650s ✓ ▁▅▁▇▂
Cached Build 2.930s 2.884s ✓ ▁▃▁▆▂
📦 Production Builds (Webpack) (Legacy)

📦 Production Builds (Webpack)

Metric Canary PR Change Trend
Fresh Build 23.561s 23.825s ✓ ▁▁▁▁▂
Cached Build 23.806s 24.714s 🔴 +908ms (+4%) ▁▁▁▁▂
node_modules Size 553 MB 553 MB ✓ ▁▁▁██
📦 Bundle Sizes

Bundle Sizes

⚡ Turbopack

Client

Main Bundles
Canary PR Change
03lzpt71kg1qg.js gzip 47 kB N/A -
050icza-xjz0i.js gzip 5.73 kB N/A -
07jdby0ue616s.js gzip 450 B N/A -
08diod4dbhoq_.js gzip 170 B N/A -
09bwho4kgfnaw.js gzip 162 B N/A -
0bjdc8muo74n5.js gzip 8.71 kB N/A -
0cz1d0mv5g_q7.js gzip 39.4 kB 39.4 kB ✓
0kyw_t3clzh5k.js gzip 160 B N/A -
0q36apx7b1q_e.js gzip 7.54 kB N/A -
0rci1f3or1a19.js gzip 13.3 kB N/A -
0z5j9cqt7-gf1.js gzip 158 B N/A -
1_2x714--ii1i.js gzip 8.76 kB N/A -
1-3y752pkth5-.js gzip 10 kB N/A -
1elt1qium-r2m.css gzip 115 B 115 B ✓
1h6ke0pxyxvuz.js gzip 159 B N/A -
1k6dd7su4cfei.js gzip 3.57 kB N/A -
1knxskedxdnbv.js gzip 155 B N/A -
1rue09cunaz5q.js gzip 71.6 kB N/A -
1tf1phijqlx9j.js gzip 220 B 220 B ✓
1uzabyd1120a1.js gzip 8.71 kB N/A -
2_t5p70_6fv1f.js gzip 164 B N/A -
2-ufv8lc-g7gg.js gzip 10.6 kB N/A -
21kmjy_10x14f.js gzip 8.81 kB N/A -
28dhc6t85q1_p.js gzip 8.78 kB N/A -
29jw-oswiv6r-.js gzip 160 B N/A -
2f-ilvczue-tp.js gzip 9.46 kB N/A -
2f1u17u5c8iny.js gzip 8.79 kB N/A -
2ikltg_8iegxw.js gzip 10.3 kB N/A -
2nunke4x8igib.js gzip 65.6 kB N/A -
2vxi673cz1-t4.js gzip 8.79 kB N/A -
30t5605gdrome.js gzip 160 B N/A -
38-q43pzktqhs.js gzip 1.46 kB N/A -
3g_3cdj20w2xf.js gzip 158 B N/A -
3mrwxzed0ylgv.js gzip 13.1 kB N/A -
3nbojhxiy1qv_.js gzip 13.7 kB N/A -
3ncdopg0nj_dy.js gzip 158 B N/A -
3qdbnsoyrpze0.js gzip 158 B N/A -
3v6plisp2om9d.js gzip 158 B N/A -
41u5s3oe2-erp.js gzip 2.29 kB N/A -
445s_9hf8o7ao.js gzip 8.76 kB N/A -
turbopack-1l..-5yv.js gzip 3.73 kB 3.73 kB ✓
0-6bcj16ji2wf.js gzip N/A 10.6 kB -
07ryk0jced-sc.js gzip N/A 8.78 kB -
0f965j8gy01t3.js gzip N/A 65.6 kB -
0hrxdiaj9hgor.js gzip N/A 155 B -
0jwho9fkrb_t3.js gzip N/A 2.29 kB -
0oz_qfl3-gs-8.js gzip N/A 156 B -
0roh390ijzxa5.js gzip N/A 8.75 kB -
0vex9w55ursqj.js gzip N/A 8.79 kB -
0xwtege24k6x-.js gzip N/A 168 B -
1-skzwhs7_pfy.js gzip N/A 155 B -
17oe55cu76cd7.js gzip N/A 450 B -
18wj45txekher.js gzip N/A 156 B -
1drww5xikb-c-.js gzip N/A 9.46 kB -
1g60xde_dv17t.js gzip N/A 8.79 kB -
1hp09atu5zu43.js gzip N/A 157 B -
1qieq1mh2hl7p.js gzip N/A 156 B -
1uzv47btzam64.js gzip N/A 5.73 kB -
1vy7n7wxv_rh5.js gzip N/A 8.81 kB -
2-0i7pl900-ou.js gzip N/A 8.71 kB -
2-kcbngm7ik7y.js gzip N/A 8.75 kB -
29p5-xa4jmdhg.js gzip N/A 13.7 kB -
2a4s3ojjvan0i.js gzip N/A 159 B -
2lpk5_hknut8q.js gzip N/A 13.1 kB -
2o4cibp3awtbw.js gzip N/A 3.56 kB -
2ugc69z0t0ypz.js gzip N/A 1.46 kB -
3-_0ow7671xjh.js gzip N/A 7.55 kB -
3-_vtzvtjvs-7.js gzip N/A 71.6 kB -
36dn8i-_3dnq5.js gzip N/A 10 kB -
3e-se-8-bjyhr.js gzip N/A 161 B -
3fljpmwcjxqhx.js gzip N/A 10.3 kB -
3gz44skqdlsrb.js gzip N/A 8.71 kB -
3nk46g6u37ekv.js gzip N/A 47 kB -
3pdspqhuxz42m.js gzip N/A 155 B -
3si3qzv5u9xnf.js gzip N/A 151 B -
3t-jxyu5y0ppe.js gzip N/A 157 B -
3uwo1hpfhdjfs.js gzip N/A 158 B -
3y9tus7kb5su0.js gzip N/A 13.3 kB -
Total 401 kB 401 kB ✅ -25 B

Server

Middleware
Canary PR Change
middleware-b..fest.js gzip 1.05 kB 1.06 kB ✓
Total 1.05 kB 1.06 kB ⚠️ +1 B
Build Details
Build Manifests
Canary PR Change
_buildManifest.js gzip 880 B 877 B ✓
Total 880 B 877 B ✅ -3 B
Build Cache
Canary PR Change
00000001.sst gzip 14 MB 13.7 MB 🟢 283 kB (-2%)
00000002.sst gzip 14.5 MB 14.6 MB 🔴 +113 kB (+1%)
00000003.sst gzip 12.3 MB 14.8 MB 🔴 +2.46 MB (+20%)
00000004.sst gzip 14.2 MB 11.9 MB 🟢 2.3 MB (-16%)
00000005.sst gzip 10.2 MB 10.2 MB 🔴 +28.6 kB (+0%)
00000006.sst gzip 2.8 MB 2.8 MB ✓
00000007.sst gzip 59 B 59 B ✓
00000008.meta gzip 89 B 89 B ✓
00000009.meta gzip 298 kB 298 kB ✓
00000010.meta gzip 298 kB 298 kB ✓
00000011.meta gzip 298 kB 298 kB ✓
00000012.sst gzip 53 kB 52.2 kB 🟢 833 B (-2%)
00000013.sst gzip 1.78 MB 1.84 MB 🔴 +58.9 kB (+3%)
00000014.sst gzip 59 B 59 B ✓
00000015.meta gzip 116 B 116 B ✓
00000016.meta gzip 326 kB 326 kB ✓
00000017.meta gzip 405 kB 406 kB ✓
00000018.sst gzip 53.6 kB 52.8 kB 🟢 762 B (-1%)
00000019.sst gzip 1.41 MB 1.39 MB 🟢 11.9 kB (-1%)
00000020.sst gzip 59 B 59 B ✓
00000021.meta gzip 116 B 116 B ✓
00000022.meta gzip 326 kB 326 kB ✓
00000023.meta gzip 372 kB 372 kB ✓
00000024.sst gzip 53.8 kB 52.9 kB 🟢 922 B (-2%)
00000025.sst gzip 1.41 MB 1.39 MB 🟢 12.1 kB (-1%)
00000026.sst gzip 59 B 59 B ✓
00000027.meta gzip 116 B 116 B ✓
00000028.meta gzip 326 kB 326 kB ✓
00000029.meta gzip 372 kB 372 kB ✓
00000030.sst gzip 53.1 kB 52.2 kB 🟢 930 B (-2%)
00000031.sst gzip 1.41 MB 1.39 MB 🟢 11.9 kB (-1%)
00000032.sst gzip 59 B 59 B ✓
00000033.meta gzip 116 B 116 B ✓
00000034.meta gzip 326 kB 326 kB ✓
00000035.meta gzip 372 kB 372 kB ✓
00000036.sst gzip 53.6 kB 52.7 kB 🟢 839 B (-2%)
00000037.sst gzip 1.41 MB 1.39 MB 🟢 12.1 kB (-1%)
00000038.sst gzip 59 B 59 B ✓
00000039.meta gzip 116 B 116 B ✓
00000040.meta gzip 326 kB 326 kB ✓
00000041.meta gzip 372 kB 372 kB ✓
CURRENT gzip 94 B 94 B ✓
LOG gzip 681 B 660 B 🟢 21 B (-3%)
Total 80.1 MB 80.1 MB ⚠️ +27.4 kB

📦 Webpack

Client

Main Bundles
Canary PR Change
3322-HASH.js gzip 66.2 kB N/A -
4191.HASH.js gzip 169 B N/A -
7920-HASH.js gzip 4.67 kB N/A -
9784-HASH.js gzip 5.63 kB N/A -
b1ad9f4c-HASH.js gzip 63.2 kB N/A -
framework-HASH.js gzip 59.7 kB 59.7 kB ✓
main-app-HASH.js gzip 253 B 252 B ✓
main-HASH.js gzip 40.1 kB 40.1 kB ✓
webpack-HASH.js gzip 1.68 kB 1.68 kB ✓
3577.HASH.js gzip N/A 168 B -
578-HASH.js gzip N/A 66.8 kB -
8590-HASH.js gzip N/A 5.61 kB -
9750-HASH.js gzip N/A 4.68 kB -
a8984546-HASH.js gzip N/A 63.2 kB -
Total 242 kB 242 kB ⚠️ +618 B
Polyfills
Canary PR Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB ✓
Total 39.4 kB 39.4 kB ✓
Pages
Canary PR Change
_app-HASH.js gzip 194 B 193 B ✓
_error-HASH.js gzip 181 B 182 B ✓
css-HASH.js gzip 334 B 331 B ✓
dynamic-HASH.js gzip 1.81 kB 1.81 kB ✓
edge-ssr-HASH.js gzip 255 B 253 B ✓
head-HASH.js gzip 349 B 351 B ✓
hooks-HASH.js gzip 382 B 384 B ✓
image-HASH.js gzip 581 B 582 B ✓
index-HASH.js gzip 260 B 259 B ✓
link-HASH.js gzip 2.48 kB 2.48 kB ✓
routerDirect..HASH.js gzip 317 B 318 B ✓
script-HASH.js gzip 384 B 386 B ✓
withRouter-HASH.js gzip 316 B 315 B ✓
1afbb74e6ecf..834.css gzip 106 B 106 B ✓
Total 7.95 kB 7.96 kB ⚠️ +4 B

Server

Edge SSR
Canary PR Change
edge-ssr.js gzip 129 kB 128 kB ✓
page.js gzip 293 kB 294 kB ✓
Total 422 kB 422 kB ✅ -214 B
Middleware
Canary PR Change
middleware-b..fest.js gzip 617 B 616 B ✓
middleware-r..fest.js gzip 156 B 156 B ✓
middleware.js gzip 45.5 kB 45.2 kB ✓
edge-runtime..pack.js gzip 842 B 842 B ✓
Total 47.1 kB 46.8 kB ✅ -269 B
Build Details
Build Manifests
Canary PR Change
_buildManifest.js gzip 717 B 718 B ✓
Total 717 B 718 B ⚠️ +1 B
Build Cache
Canary PR Change
0.pack gzip 4.8 MB 4.8 MB ✓
index.pack gzip 122 kB 121 kB ✓
index.pack.old gzip 122 kB 122 kB ✓
Total 5.04 MB 5.04 MB ✅ -5.27 kB

🔄 Shared (bundler-independent)

Runtimes
Canary PR Change
app-page-exp...dev.js gzip 374 kB 374 kB ✓
app-page-exp..prod.js gzip 207 kB 207 kB ✓
app-page-tur...dev.js gzip 374 kB 374 kB ✓
app-page-tur..prod.js gzip 206 kB 206 kB ✓
app-page-tur...dev.js gzip 370 kB 370 kB ✓
app-page-tur..prod.js gzip 204 kB 204 kB ✓
app-page.run...dev.js gzip 371 kB 371 kB ✓
app-page.run..prod.js gzip 204 kB 204 kB ✓
app-route-ex...dev.js gzip 82.6 kB 82.6 kB ✓
app-route-ex..prod.js gzip 55.8 kB 55.8 kB ✓
app-route-tu...dev.js gzip 82.7 kB 82.7 kB ✓
app-route-tu..prod.js gzip 55.8 kB 55.8 kB ✓
app-route-tu...dev.js gzip 82.3 kB 82.3 kB ✓
app-route-tu..prod.js gzip 55.6 kB 55.6 kB ✓
app-route.ru...dev.js gzip 82.2 kB 82.2 kB ✓
app-route.ru..prod.js gzip 55.6 kB 55.6 kB ✓
dev-validati...dev.js gzip 134 kB 134 kB ✓
dev-validati...dev.js gzip 134 kB 134 kB ✓
dev-validati...dev.js gzip 131 kB 131 kB ✓
dev-validati...dev.js gzip 131 kB 131 kB ✓
dist_client_...dev.js gzip 324 B 324 B ✓
dist_client_...dev.js gzip 326 B 326 B ✓
dist_client_...dev.js gzip 318 B 318 B ✓
dist_client_...dev.js gzip 317 B 317 B ✓
pages-api-tu...dev.js gzip 46.1 kB 46.1 kB ✓
pages-api-tu..prod.js gzip 34.3 kB 34.3 kB ✓
pages-api.ru...dev.js gzip 46 kB 46 kB ✓
pages-api.ru..prod.js gzip 34.3 kB 34.3 kB ✓
pages-turbo....dev.js gzip 54.8 kB 54.8 kB ✓
pages-turbo...prod.js gzip 39.8 kB 39.8 kB ✓
pages.runtim...dev.js gzip 54.8 kB 54.8 kB ✓
pages.runtim..prod.js gzip 39.8 kB 39.8 kB ✓
server.runti..prod.js gzip 66.8 kB 66.8 kB ✓
use-cache-pr...dev.js gzip 72.3 kB 72.3 kB ✓
use-cache-pr...dev.js gzip 72.3 kB 72.3 kB ✓
use-cache-pr...dev.js gzip 70.6 kB 70.6 kB ✓
use-cache-pr...dev.js gzip 70.5 kB 70.5 kB ✓
Total 4.1 MB 4.1 MB ✅ -1 B
📝 Changed Files (2 files)

Files with changes:

  • pages-api-tu..time.prod.js
  • pages-turbo...time.prod.js
View diffs
pages-api-tu..time.prod.js

Diff too large to display

pages-turbo...time.prod.js

Diff too large to display

📎 Tarball URL 
https://vercel-packages.vercel.app/next/commits/daca98d21025774d2b177796734993c71a300bfe/next

Commit: daca98d

@eps1lon
eps1lon requested a review from unstubbable August 12, 2026 11:25
@eps1lon
eps1lon marked this pull request as ready for review August 12, 2026 11:25
@eps1lon
eps1lon enabled auto-merge (squash) August 12, 2026 11:26
@eps1lon
eps1lon merged commit c20fd66 into canary Aug 12, 2026
232 of 234 checks passed
@eps1lon
eps1lon deleted the sebbie/ncc-msw-resolver-polyfill branch August 12, 2026 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@unstubbable unstubbable unstubbable approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@eps1lon @unstubbable