fix(ui): fix duplicate colored error message#10258
Merged
sheremet-va merged 8 commits intoMay 11, 2026
Merged
Conversation
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
✅ Deploy Preview for vitest-dev ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
hi-ogawa
commented
May 11, 2026
Comment on lines
-64
to
-78
| function createHtmlError(filter: Convert, error: TestError) { | ||
| let htmlError = '' | ||
| if (error.message?.includes('\x1B')) { | ||
| htmlError = `<b>${error.name}</b>: ${filter.toHtml( | ||
| escapeHtml(error.message), | ||
| )}` | ||
| } | ||
|
|
||
| const startStrWithX1B = error.stack?.includes('\x1B') | ||
| if (startStrWithX1B) { | ||
| if (htmlError.length > 0) { | ||
| htmlError += filter.toHtml( | ||
| escapeHtml((error.stack) as string), | ||
| ) | ||
| } |
Collaborator
Author
There was a problem hiding this comment.
this code was duplicating error.message since error.stack normally includes error.message.
sheremet-va
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
There was a buggy code path for colored
error.messagehandling. As I didn't see the need of involved logic aroundhtmlError, I simplified it and letViewReportErrorformat the error uniformly even though we could patch up buggy htmlError.Here is a before and after of the change:
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Tests
pnpm test:ci.Documentation
pnpm run docscommand.Changesets
feat:,fix:,perf:,docs:, orchore:.