fix(reporters): summary to intercept logger's streams even when they are not process.std* streams#10340
Merged
hi-ogawa merged 2 commits intoMay 15, 2026
Conversation
AriPerkkio
commented
May 13, 2026
✅ Deploy Preview for vitest-dev ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
AriPerkkio
commented
May 13, 2026
Comment on lines
+52
to
+53
| this.interceptStream(options.logger.outputStream, 'output'), | ||
| this.interceptStream(options.logger.errorStream, 'error'), |
Member
Author
There was a problem hiding this comment.
This part fixes a bug where virtual buffer would not capture logger.log calls that were made by other reporters when custom VitestOptions.stdout was used.
c600bd2 to
b6a933a
Compare
…y are not `process.std*` streams
b6a933a to
db5efcc
Compare
hi-ogawa
reviewed
May 14, 2026
6e3bde5 to
88c2423
Compare
hi-ogawa
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
While adding test cases for summary reporter, I noticed bug around window rendered. It's really edge-case bug that happens only when using Node API and passing custom
stdout/stderrwhile using summary reporter.So this is more of a
test(reporter): summary reporter teststhan afix:, but fix has more priority.Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Tests
pnpm test:ci.Documentation
pnpm run docscommand.Changesets
feat:,fix:,perf:,docs:, orchore:.