fix(browser)!: require sessionId for orchestrator html request#10522
Merged
sheremet-va merged 10 commits intoJun 8, 2026
Conversation
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
hi-ogawa
commented
Jun 5, 2026
| ['p', 'filter by a filename'], | ||
| ['t', 'filter by a test name regex pattern'], | ||
| ['w', 'filter by a project name'], | ||
| ['b', 'start the browser server if not started yet'], |
Collaborator
Author
There was a problem hiding this comment.
From a quick look, b doesn't do anything meaningful now? I may have missed some context, so will verify later with
Collaborator
Author
There was a problem hiding this comment.
Yes, this doesn't look doing anything meaningful, so propose removing it together. The current behavior is explained in:
Member
There was a problem hiding this comment.
It should be printed for preview at least, because it's possible that openPage doesn't open the browser correctly
I think the main use case for b was to start the browsers in the standalone mode, but we fixed that separetly
This was referenced Jun 8, 2026
Co-authored-by: Codex <noreply@openai.com>
✅ Deploy Preview for vitest-dev ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
Co-authored-by: Codex <noreply@openai.com>
sheremet-va
approved these changes
Jun 8, 2026
This was referenced Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
bshould be redesigned as a real browser-session shortcut or removed #10538Previously any request to
/__vitest_test__serves the same html as/__vitest_test__/?sessionId=...even though the direct request to/__vitest_test__doesn't provide working browser mode experience. This PR changes to return 404 on/__vitest_test__to reduce exposed API credentials surface.TODO
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Tests
pnpm test:ci.Documentation
pnpm run docscommand.Changesets
feat:,fix:,perf:,docs:, orchore:.