Do not escape values in text emails - #478
Merged
Merged
Conversation
Collaborator
|
Thank you for your contribution! I think it is worth separating out cases where un-escaped values may be required (links) and where they are not (potentially un-trusted input like user names). |
Contributor
Author
|
I don't think you want to have the app title or username escaped in text emails. If the app title is something like '' you don't want it to have '<voidauth>' in text emails. Even usernames should not be escaped. In text emails there is no possibility that untrusted input is displayed wrong even when unescaped. |
Collaborator
|
Looks like you are right, I will review and merge this in if I don't have any feedback |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In text emails the values should not be xml escaped. At least in the invitation emails this causes broken links, because the
&in the url is escaped as&.AI Usage
There was no AI used for this commit.
Screenshots
No visual changes.