Add support for docker secrets via FILE__ variables - #501
Merged
Conversation
Collaborator
|
Thank you for your contribution! This is quite clever, and implements a feature I have been holding on the back-burner. I will take a closer look at this and do some testing, and will let you know if I have any feedback |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for docker secrets, by reading configuration options from either environment variables (the usual) or the given files (path provided via
FILE__VARenv vars).I did minimal changes to the
config.ts; I manually tested it works. I'm open to suggestions on how to reword documentation or even the base compose.yml to indicate how to use secrets.For context, something like the following works:
Related Tickets & Documents
I couldn't find any recent or old issue or PR related to docker secrets. Let me know if I should open one to track this feature.
About docker secrets: https://docs.docker.com/reference/compose-file/secrets/
AI Usage
I did not use AI to write this code.
Screenshots
N/A