fix: disable default Cross-Origin-Opener-Policy header for popup OIDC flows - #515
Merged
notquitenothing merged 2 commits intoJul 23, 2026
Merged
Conversation
Collaborator
|
I would prefer a simpler version of this, just setting |
denkristoffer
force-pushed
the
fix/disable-coop-popup-oidc
branch
from
July 22, 2026 08:18
72696be to
ce15fef
Compare
Contributor
Author
@notquitenothing Sure, I've removed the extras 🙂 |
notquitenothing
approved these changes
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Disable the
Cross-Origin-Opener-Policy: same-originheader that gets set by default byHelmet. The policy places cross-origin popup pages in a separate browsing-context, which meanswindow.openerisnull. Some OIDC clients rely on the opener to complete the login handoff. I saw this cause problems with Synology DSM and with Komga.I also added a backend test and npm script to run it. Let me know if you don't want this.Related Tickets & Documents
None
AI Usage
I used Codex with gpt-5.6 to write the regression test.Screenshots
N/A