Skip to content

Add Turntable camera controller example #354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
robertosfield merged 3 commits into from
Jun 16, 2025
Merged

Add Turntable camera controller example #354

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
877cf3c
Add Turntable controller source and runner
nolankramer May 9, 2025
50865bf
Add license mit
nolankramer May 9, 2025
cf79ac5
Rotation fix: use std::abs()
nolankramer May 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Rotation fix: use std::abs()
  • Loading branch information
@nolankramer
nolankramer committed May 14, 2025
commit cf79ac567d845fea4fa50ed580551faf2467f6a8
6 changes: 3 additions & 3 deletions examples/app/vsgturntablecamera/Turntable.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -466,7 +466,7 @@ void Turntable::apply(vsg::FrameEvent& frame)
computeRotationAxesWithGimbalAvoidance(horizontalAxis, verticalAxis, lookVector, globalUp);

// Apply horizontal rotation
double horizontalAngle = _rotateAngle * (1.0 - abs(verticalComponent)) * scale;
double horizontalAngle = _rotateAngle * (1.0 - std::abs(verticalComponent)) * scale;
rotate(horizontalAngle, horizontalAxis);

// Apply vertical rotation
Expand Down Expand Up @@ -526,7 +526,7 @@ void Turntable::computeRotationAxesWithGimbalAvoidance(vsg::dvec3& horizontalAxi
const vsg::dvec3& lookVector, const vsg::dvec3& globalUp)
{
// 1. Compute how close we are to gimbal lock
double viewVerticalAlignment = abs(vsg::dot(lookVector, globalUp));
double viewVerticalAlignment = std::abs(vsg::dot(lookVector, globalUp));

// The closer viewVerticalAlignment is to 1.0, the closer we are to gimbal lock

Expand Down Expand Up @@ -563,7 +563,7 @@ void Turntable::computeRotationAxesWithGimbalAvoidance(vsg::dvec3& horizontalAxi

void Turntable::rotate(double angle, const vsg::dvec3& axis)
{
if (abs(angle) < 1e-10 || vsg::length(axis) < 1e-10)
if (std::abs(angle) < 1e-10 || vsg::length(axis) < 1e-10)
return;

// Create rotation matrix around the provided axis
Expand Down