Address transaction state edge cases - #447
Merged
Merged
Conversation
Member
Author
|
@stelar7 can you take a look? |
* Clarify that only inactive transactions should auto-commit. * Fix upgrade steps to correctly handle aborted transactions. Resolves #436
inexorabletash
force-pushed
the
transaction-state-fixes
branch
from
April 11, 2025 19:34
fc928ae to
66fa597
Compare
stelar7
approved these changes
Apr 12, 2025
SteveBeckerMSFT
approved these changes
Apr 24, 2025
SteveBeckerMSFT
left a comment
Collaborator
There was a problem hiding this comment.
Sorry for the delay. Looks good to me. Thanks for fixing the extra brackets around my detached buffer change. Not sure how I missed that.
github-actions Bot
added a commit
that referenced
this pull request
Apr 24, 2025
SHA: fe4a092 Reason: push, by inexorabletash Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clarify that only inactive transactions should auto-commit.
Fix upgrade steps to correctly handle aborted transactions.
Resolves #436
Preview | Diff