use preferred wording introduced in aria-description PR - #1149
Conversation
scottaohara
left a comment
There was a problem hiding this comment.
LGTM aside from the extra spaces in the source code :)
|
Seems to mix "in the DOM" and "visible label: references: Here is a suggested edit: |
jongund
left a comment
There was a problem hiding this comment.
@jnurthen I added a comment on some suggested wording, the current pull request starts out with "in the DOM" and the switches to "Visible Text", seems like we should be more consistent in how we refer to aria-labelledby content.
…elledby points to
|
Good catch, @jongund. Thanks for reading the whole paragraph. I've committed your suggested text. |
* use "DOM content" instead of "visible text" to describe what aria-labelledby points to
* use "DOM content" instead of "visible text" to describe what aria-labelledby points to
When saying what determines when to use aria-labelledby over aria-label, use:
instead of:
Preview | Diff