Skip to content

resolves #1407 by changing example in aria-brailleroledescription - #1409

Merged
jnurthen merged 3 commits into
mainfrom
issue-1407
Mar 4, 2021
Merged

resolves #1407 by changing example in aria-brailleroledescription#1409
jnurthen merged 3 commits into
mainfrom
issue-1407

Conversation

@cookiecrook

@cookiecrook cookiecrook commented Feb 23, 2021

Copy link
Copy Markdown
Contributor

resolves #1407


Preview | Diff

@carmacleod carmacleod left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 looks good

Although... consider using <section> instead of <div role="region"> and not using aria-labelledby?
i.e. 42 landmarks might be a bit much, but 42 h1's is probably ok? :)

…nge this and similar examples from section to article role
@cookiecrook

cookiecrook commented Feb 25, 2021

Copy link
Copy Markdown
Contributor Author

+1 looks good

Although... consider using <section> instead of <div role="region"> and not using aria-labelledby?

I wanted to show this used in combination with an explicit role. The aria-roledescription section already has both the implicit and explicit role examples.

i.e. 42 landmarks might be a bit much, but 42 h1's is probably ok? :)

Removed the number and changed the roles to article, based on discussion in the call today.

@carmacleod

Copy link
Copy Markdown
Contributor

Thanks @cookiecrook !
Should Example 31 use HTML <article> (instead of <section>) for consistency?

@cookiecrook cookiecrook added this to the ARIA 1.3 milestone Mar 3, 2021
@pkra
pkra self-requested a review March 3, 2021 21:03
@jnurthen
jnurthen merged commit c38c9af into main Mar 4, 2021
@pkra pkra mentioned this pull request Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

aria-brailleroledescription example conflicts with recommended authoring practices

4 participants