Refactor identification of global states and properties - #1833
Conversation
jnurthen
left a comment
There was a problem hiding this comment.
This looks great with a few tweaks. Thanks so much!
| node.replaceChild(l, parentNode); | ||
| } | ||
| } | ||
| // Annotate global attribute references |
There was a problem hiding this comment.
This file is maintained in aria-common - but having it here is great for now as it lets us test the changes.
There was a problem hiding this comment.
Ah, I see, thanks. Once this PR is finalized, would it be appropriate for me to create a separate PR for this file in the aria-common repo?
|
Hi @cyns , you mentioned a related issue in our weekly meeting today, but my brain was in scribing mode and I fear I missed the details. 😅 I searched our open issue list for “taxonomy” and “parent” but didn’t find anything that seemed applicable. Could I trouble you to help me track that down? |
|
Closing this as outdated -- this needs to wait until aria.js is refactored (in aria-common). |
Closes #1823.
In reviewing the list of global states and properties, I found considerable overlap with the attributes already classified in the “6.6 Taxonomy...” section. As @JAWS-test reported, I discovered only 6 attributes that were missing from Taxonomy:
aria-braillelabelaria-brailleroledescriptionaria-currentaria-descriptionaria-keyshortcutsaria-roledescriptionIn this commit, I’m proposing a refactor which:
Adds the 6 missing states and properties to the Taxonomy section:
I put
aria-braillelabelin the “Widget Attributes” category since its purpose is similar toaria-label, which had already been classified in that list.I also put
aria-keyshortcutsin the “Widget Attributes” category since it felt like it belongs there.For now, I’ve put the remaining four in a new “Other Attributes” category since they didn’t appear to fit cleanly in any of the existing ones.
Updates
aria.jsto identify all global attributes in the Taxonomy section with an annotation of “(Global)” or similar.Removes the “Global States & Properties” section, but incorporates its descriptive language into the Taxonomy section.
Relocate the “Translatable Attributes” section so that the Taxonomy section may be more clearly understood as a complete collection of all ARIA attributes.
Preview | Diff