Editorial: Fixing links to APG and the naming of the APG document in text. - #1982
Merged
Conversation
spectranaut
requested changes
Jul 20, 2023
spectranaut
left a comment
Contributor
There was a problem hiding this comment.
Hmmm unfortunately there are some unrelated changes that got stuck in the PR, it looks like a revert of the changes that where landed here: #1945
Is this something you can fix @MarioBatusic ? It will be a little tricky to get those changes out of your commit.
Contributor
Author
|
Hi Valerie,
Can you explain the problem a bit. No idea what the problem is.
Thanks.
Ciao Mario
Von: Valerie Young ***@***.***>
Gesendet: Donnerstag, 20. Juli 2023 21:31
An: w3c/aria ***@***.***>
Cc: Batusic, Mario ***@***.***>; Mention ***@***.***>
Betreff: Re: [w3c/aria] Editorial: Fixing links to APG and the naming of the APG document in text. (PR #1982)
@spectranaut requested changes on this pull request.
Hmmm unfortunately there are some unrelated changes that got stuck in the PR, it looks like a revert of the changes that where landed here: #1945<#1945>
Is this something you can fix @MarioBatusic<https://github.com/MarioBatusic> ? It will be a little tricky to get those changes out of your commit.
—
Reply to this email directly, view it on GitHub<#1982 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AC2VBNE34VUHX7ZPFHT57S3XRGBO3ANCNFSM6AAAAAA2ODZZU4>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Contributor
Author
|
So, now I think I have repaired the PR error. Please merge it. |
spectranaut
approved these changes
May 2, 2024
spectranaut
approved these changes
May 2, 2024
spectranaut
left a comment
Contributor
There was a problem hiding this comment.
I made a mistake when handling the merge conflict, I'll fix and this is good to go!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preview | Diff