editorial: CI for roleInfo.js - #2625
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Ok, well, as you say, this is pretty silly, but I'm fine with it as an intermediate step!
I looked at the code but not enough to try to think of suggesting anything differently. Let me know if you want me to think harder about it.
Edit: oh now I see maybe you want to answer these other questions before landing. I will come back to this and think about it.
|
Discussed in yesterday's editors' call https://www.w3.org/2025/09/10-aria-editors-minutes.html#73b0 From there:
|
|
@spectranaut it occurs to me that running this on a PR to show a diff will never get us an update. Should it also silently run updates on main? |
b29bb5e to
2f9ec60
Compare
First working draft of a CI approach. - common/script/buildRoleInfo.js - currently very hacky way of running aria.js using linkedom - roleInfo.yml - standard nodejs setup - installs linkedom and runs buildRoleInfo.js to update roleInfo Part of #2501
5278f29 to
ce138b9
Compare
As per editors' decision.
As per editor's decision, this action fails when a PR creates changes in roleInfo.js; it is meant to trigger review.
Prevents "nothing to commit" errors when there are no changes.
✅ Deploy Preview for wai-aria ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Runs prettier to match current output.
Uses npx to find prettier.
|
Discussed in the editors' call today https://www.w3.org/2025/10/08-aria-editors-minutes.html#fae4 |
|
@daniel-montalvo I looked into the question from yesterday's call. From what I've gathered, I think github actions will run into the same problem with forks that we tried to avoid - the action on the fork won't have write access to the PR thread. I think your idea would require a more complex solution (like the netlify tooling). |
|
@daniel-montalvo if you agree, could we merge this and find a solution for surfacing the diff later? That way we can continue the work on aria.js |
|
Sure, +1 to merging this as-is for now. |
|
Well, that didn't work. |
SHA: 04f4485 Reason: push, by pkra Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
@daniel-montalvo @spectranaut @jnurthen it turns out the idea to regenerate roleInfo on the main branch won't work because the branch is protected. Any ideas? |
|
@daniel-montalvo I'll make a PR that matches prettier.yaml's checkout settings (since that obviously works). |
Adds github actions and scripts to enable automatic checking and updating of roleInfo.js - common/script/buildRoleInfo.js - currently very hacky way of running aria.js using linkedom (see #2501 for plans on removing hackery) - roleInfo.yml: updates roleInfo.js on pushes to main - standard nodejs setup - installs linkedom and runs buildRoleInfo.js to update roleInfo - roleInfoCheck.yml: checks PRs if they introduce changes to roleInfo.js - similar to roleInfo.yml but only reports on git diff (no commit) Part of #2501
Adds github actions and scripts to enable automatic checking and updating of roleInfo.js
Part of #2501
Preview | Diff