Conversation
Resolves one TODO item, fixing (a few) roles tables so that inherited roles appear in the correct table (and only there). Part of #2501
pkra
marked this pull request as ready for review
March 23, 2026 17:18
✅ Deploy Preview for wai-aria ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
🚀 Deployed on https://deploy-preview-2756--wai-aria.netlify.app |
Member
Author
|
@daniel-montalvo would it be possible to get a diff version when aria.js is changed? |
Contributor
|
Yes, I could do that @pkra -- not sure if we would prefer to merge this and have that done later, or we'd better wait until we have the diff to review this? |
Member
Author
|
@daniel-montalvo this PR produces changes in the spec that I think need review (though technically for attributes the characteristics tables are informative). I'll add a comment with a manual diff (running respec before and after) but it will be more difficult for reviewers. |
Member
Author
|
Here's a diff between the current diff --git a/index.html b/index.html
index 16162350..e71bd24e 100644
--- a/index.html
+++ b/index.html
@@ -13117,7 +13117,6 @@ button.<span class="hljs-property">ariaPressed</span>; <span class="hljs-comment
<tr>
<th class="state-descendants-head" scope="row">Inherits into Roles:</th>
<td class="state-descendants"><ul>
-<li><a href="https://w3c.github.io/aria/#switch" class="role-reference"><code>switch</code></a></li>
<li><a href="https://w3c.github.io/aria/#treeitem" class="role-reference"><code>treeitem</code></a></li>
</ul>
</td>
@@ -13433,6 +13432,7 @@ button.<span class="hljs-property">ariaPressed</span>; <span class="hljs-comment
<th class="property-descendants-head" scope="row">Inherits into Roles:</th>
<td class="property-descendants"><ul>
<li><a href="https://w3c.github.io/aria/#columnheader" class="role-reference"><code>columnheader</code></a></li>
+ <li><a href="https://w3c.github.io/aria/#gridcell" class="role-reference"><code>gridcell</code></a></li>
<li><a href="https://w3c.github.io/aria/#rowheader" class="role-reference"><code>rowheader</code></a></li>
</ul>
</td>
@@ -13484,6 +13484,7 @@ button.<span class="hljs-property">ariaPressed</span>; <span class="hljs-comment
<th class="property-descendants-head" scope="row">Inherits into Roles:</th>
<td class="property-descendants"><ul>
<li><a href="https://w3c.github.io/aria/#columnheader" class="role-reference"><code>columnheader</code></a></li>
+ <li><a href="https://w3c.github.io/aria/#gridcell" class="role-reference"><code>gridcell</code></a></li>
<li><a href="https://w3c.github.io/aria/#rowheader" class="role-reference"><code>rowheader</code></a></li>
</ul>
</td>
@@ -14218,7 +14219,6 @@ button.<span class="hljs-property">ariaPressed</span>; <span class="hljs-comment
<li><a href="https://w3c.github.io/aria/#columnheader" class="role-reference"><code>columnheader</code></a></li>
<li><a href="https://w3c.github.io/aria/#menuitemcheckbox" class="role-reference"><code>menuitemcheckbox</code></a></li>
<li><a href="https://w3c.github.io/aria/#menuitemradio" class="role-reference"><code>menuitemradio</code></a></li>
-<li><a href="https://w3c.github.io/aria/#rowheader" class="role-reference"><code>rowheader</code></a></li>
<li><a href="https://w3c.github.io/aria/#switch" class="role-reference"><code>switch</code></a></li>
</ul>
</td>
@@ -15541,7 +15541,6 @@ button.<span class="hljs-property">ariaPressed</span>; <span class="hljs-comment
<tr>
<th class="property-descendants-head" scope="row">Inherits into Roles:</th>
<td class="property-descendants"><ul>
-<li><a href="https://w3c.github.io/aria/#comment" class="role-reference"><code>comment</code></a></li>
<li><a href="https://w3c.github.io/aria/#menuitemcheckbox" class="role-reference"><code>menuitemcheckbox</code></a></li>
<li><a href="https://w3c.github.io/aria/#menuitemradio" class="role-reference"><code>menuitemradio</code></a></li>
<li><a href="https://w3c.github.io/aria/#treeitem" class="role-reference"><code>treeitem</code></a></li>
@@ -16271,6 +16270,7 @@ button.<span class="hljs-property">ariaPressed</span>; <span class="hljs-comment
<th class="property-descendants-head" scope="row">Inherits into Roles:</th>
<td class="property-descendants"><ul>
<li><a href="https://w3c.github.io/aria/#columnheader" class="role-reference"><code>columnheader</code></a></li>
+ <li><a href="https://w3c.github.io/aria/#gridcell" class="role-reference"><code>gridcell</code></a></li>
<li><a href="https://w3c.github.io/aria/#rowheader" class="role-reference"><code>rowheader</code></a></li>
</ul>
</td>
@@ -16433,7 +16433,6 @@ button.<span class="hljs-property">ariaPressed</span>; <span class="hljs-comment
<tr>
<th class="property-descendants-head" scope="row">Inherits into Roles:</th>
<td class="property-descendants"><ul>
-<li><a href="https://w3c.github.io/aria/#comment" class="role-reference"><code>comment</code></a></li>
<li><a href="https://w3c.github.io/aria/#menuitemcheckbox" class="role-reference"><code>menuitemcheckbox</code></a></li>
<li><a href="https://w3c.github.io/aria/#menuitemradio" class="role-reference"><code>menuitemradio</code></a></li>
<li><a href="https://w3c.github.io/aria/#treeitem" class="role-reference"><code>treeitem</code></a></li>
@@ -16557,9 +16556,6 @@ button.<span class="hljs-property">ariaPressed</span>; <span class="hljs-comment
<td class="property-descendants"><ul>
<li><a href="https://w3c.github.io/aria/#meter" class="role-reference"><code>meter</code></a></li>
<li><a href="https://w3c.github.io/aria/#progressbar" class="role-reference"><code>progressbar</code></a></li>
-<li><a href="https://w3c.github.io/aria/#scrollbar" class="role-reference"><code>scrollbar</code></a></li>
-<li><a href="https://w3c.github.io/aria/#slider" class="role-reference"><code>slider</code></a></li>
-<li><a href="https://w3c.github.io/aria/#spinbutton" class="role-reference"><code>spinbutton</code></a></li>
</ul>
</td>
</tr>
@@ -16614,9 +16610,6 @@ button.<span class="hljs-property">ariaPressed</span>; <span class="hljs-comment
<td class="property-descendants"><ul>
<li><a href="https://w3c.github.io/aria/#meter" class="role-reference"><code>meter</code></a></li>
<li><a href="https://w3c.github.io/aria/#progressbar" class="role-reference"><code>progressbar</code></a></li>
-<li><a href="https://w3c.github.io/aria/#scrollbar" class="role-reference"><code>scrollbar</code></a></li>
-<li><a href="https://w3c.github.io/aria/#slider" class="role-reference"><code>slider</code></a></li>
-<li><a href="https://w3c.github.io/aria/#spinbutton" class="role-reference"><code>spinbutton</code></a></li>
</ul>
</td>
</tr>
@@ -16683,11 +16676,7 @@ button.<span class="hljs-property">ariaPressed</span>; <span class="hljs-comment
<tr>
<th class="property-descendants-head" scope="row">Inherits into Roles:</th>
<td class="property-descendants"><ul>
-<li><a href="https://w3c.github.io/aria/#meter" class="role-reference"><code>meter</code></a></li>
<li><a href="https://w3c.github.io/aria/#progressbar" class="role-reference"><code>progressbar</code></a></li>
-<li><a href="https://w3c.github.io/aria/#scrollbar" class="role-reference"><code>scrollbar</code></a></li>
-<li><a href="https://w3c.github.io/aria/#slider" class="role-reference"><code>slider</code></a></li>
-<li><a href="https://w3c.github.io/aria/#spinbutton" class="role-reference"><code>spinbutton</code></a></li>
</ul>
</td>
</tr>
@@ -16743,7 +16732,6 @@ button.<span class="hljs-property">ariaPressed</span>; <span class="hljs-comment
<li><a href="https://w3c.github.io/aria/#progressbar" class="role-reference"><code>progressbar</code></a></li>
<li><a href="https://w3c.github.io/aria/#scrollbar" class="role-reference"><code>scrollbar</code></a></li>
<li><a href="https://w3c.github.io/aria/#slider" class="role-reference"><code>slider</code></a></li>
-<li><a href="https://w3c.github.io/aria/#spinbutton" class="role-reference"><code>spinbutton</code></a></li>
</ul>
</td>
</tr>All the removed lines should be duplicates from previous line. All added lines should be editorial corrections. |
Contributor
|
@pkra I finally could get to this. We now have the main ARIA spec diff triggered on changes to any .js file. The logic for this could be improved, especially because if we ever make changes to the ariaChild.js file this still would think they belong to the ARIA spec, but changes to that are rare I just checked the first couple of changes that you pasted here and they make sense, would be nice if you could check the rest to see if the diff is meaningful. If this works as expected, I could work later on making the logic for thiss a little bit more robust. |
Member
Author
|
@daniel-montalvo thanks! The diff looks good and should make review a breeze. |
Member
Author
|
@daniel-montalvo @jnurthen could either of you review this? |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
jnurthen
approved these changes
Apr 9, 2026
github-actions Bot
added a commit
that referenced
this pull request
Apr 10, 2026
SHA: 275a7ef Reason: push, by pkra Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Netlify Preview:
🔄 this PR updates the following sspecs:
Resolves one TODO item, fixing (a few) roles tables so that inherited roles appear in the correct table (and only there).
Part of #2501