Skip to content

Require all owning documents to have permission policy enabled - #239

Merged
kenchris merged 7 commits into
w3c:mainfrom
kenchris:main
Oct 19, 2023
Merged

Require all owning documents to have permission policy enabled#239
kenchris merged 7 commits into
w3c:mainfrom
kenchris:main

Conversation

@kenchris

@kenchris kenchris commented Oct 18, 2023

Copy link
Copy Markdown
Contributor

@kenchris

Copy link
Copy Markdown
Contributor Author

Failure is due to respec.org being down!

@rakuco rakuco left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The idea sounds good, I wonder if this spec is the first to implement this kind of check.

Can you mention this novel approach in the "Policy control" section? Maybe it's worth discussing it in "Mitigation strategies" too.

Comment thread index.html Outdated
</ol>
</li>
<aside class="issue">
<a href="https://github.com/wicg/compute-pressure/issues/110">

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<a href="https://github.com/wicg/compute-pressure/issues/110">
<a href="https://github.com/w3c/compute-pressure/issues/110">

Comment thread index.html Outdated
<a href="https://github.com/wicg/compute-pressure/issues/110">
Permission policy doesn't support workers yet #110
</a>
Permission policy doesn't support workers directly yet #110</a>, so they cannot be set per

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Permission policy doesn't support workers directly yet #110</a>, so they cannot be set per
Permission policy does not support workers directly yet (#110)</a>, so they cannot be set per

Comment thread index.html
Comment thread index.html Outdated
Shared workers often have multiple owning documents as they can be obtained
by other documents with the [=same origin=].

In this case, all owning documents have to have the permission policy allowed

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is "have the permission policy allowed" a common way of phrasing this? It sounds a bit confusing.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I tried changing it a few times, but didn't find a good wording :-) Maybe @anssiko has some good suggestions

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about just using allowed to use like in observe()?

"[...] all owning documents must be allowed to use the policy-controlled feature defined by this specification", for example.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, done

@rakuco rakuco left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with a nit

Comment thread index.html Outdated
Co-authored-by: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
@kenchris
kenchris merged commit 2873936 into w3c:main Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants