Skip to content

[css-view-transitions-1] Rename domUpdated to updateCallbackDone - #8330

Merged
jakearchibald merged 2 commits into
w3c:mainfrom
vmpstr:rename-dom-updated
Jan 19, 2023
Merged

[css-view-transitions-1] Rename domUpdated to updateCallbackDone#8330
jakearchibald merged 2 commits into
w3c:mainfrom
vmpstr:rename-dom-updated

Conversation

@vmpstr

@vmpstr vmpstr commented Jan 18, 2023

Copy link
Copy Markdown
Member

[css-view-transitions-1] Rename domUpdated to updateCallbackDone

Fixes #8144

@jakearchibald

jakearchibald commented Jan 18, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Feels like we should also rename the callback as part of this.

Stuff to rename (IMO):

  • updateDOMCallback to updateCallback
  • "DOM update callback" to "update callback"
  • "dom-update-callback-called" to "update-callback-called"
  • "call the DOM update callback" to "call the update callback"

@vmpstr

vmpstr commented Jan 19, 2023

Copy link
Copy Markdown
Member Author

Done. PTAL

@jakearchibald
jakearchibald merged commit b44d8c0 into w3c:main Jan 19, 2023
@vmpstr
vmpstr deleted the rename-dom-updated branch January 19, 2023 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jakearchibald jakearchibald jakearchibald approved these changes
@khushalsagar khushalsagar Awaiting requested review from khushalsagar

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[css-view-transitions-1] domUpdated isn't the right term

2 participants

@vmpstr @jakearchibald