-
Notifications
You must be signed in to change notification settings - Fork 804
[css-images-4] Add two png images to example 33 to the stripes() function #9719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
711bc58
3249aab
42897f8
b877144
ee577e1
8355dd9
f79b2d0
6a95598
5f22bc1
1c20316
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2011,7 +2011,9 @@ Color Stop “Fixup”</h4> | |
| will result in a 100px red stripe and 200px green stripe, | ||
| giving red 1 share and green 2 shares of the 300px remaining | ||
| after subtracting blue's 100px from the 400px total. | ||
|
|
||
|
|
||
| <img src="images/stripes-example-33-1.png" style="height:1em; width:400px;" alt="example 1"> | ||
|
|
||
| On the other hand, | ||
| ''stripes(red .1fr, green .2fr, blue 100px)'' | ||
| with a |total width| of ''400px'' | ||
|
|
@@ -2022,7 +2024,9 @@ Color Stop “Fixup”</h4> | |
| to obtain only 90px, | ||
| which is then distributed in the 1:2 ratio | ||
| dictated by the <<flex>> values. | ||
|
|
||
|
|
||
| <img src="images/example33-2.png" style="height: 1em; width:400px;" alt="example 2"> | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Like above, maybe better an SVG than a PNG. Simply name it "stripes2" to avoid numbering issues when other example images are added. And if you want it add an alternative text, here's an example description: |
||
|
|
||
| (This is similar to how [=flex layout=] deals with small <<flex>> sums on a line, | ||
| and ensures smoothly continuous behavior | ||
| as the <<flex>> values approach zero.) | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe use and SVG instead of a PNG?
Please also avoid the example number in the name and just call it "stripes1", as the example number may change when other examples are added.
And if you want to provide an alternative text ‒ which is probably not needed as the output is already explained above the image ‒ it should provide a proper description of the image (see also https://www.w3.org/WAI/tutorials/images/tips/). So something like that:
"Horizontal line with a total width of 400 pixels showing the output of 'stripes(red 1fr, green 2fr, blue 100px)'. The left-most part is a red stripe of 100 pixels length, followed by a green stripe of 200 pixels, and a blue stripe of 100 pixels.".