Media overlay fragments - #1663
Merged
Merged
Conversation
…extref attributes
# Conflicts: # epub33/core/index.html # epub33/rs/index.html
marisademeglio
approved these changes
May 5, 2021
dauwhe
approved these changes
May 5, 2021
dauwhe
left a comment
Contributor
There was a problem hiding this comment.
I like that this references HTML and (indirectly) the URL spec.
iherman
approved these changes
May 6, 2021
wareid
approved these changes
May 6, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here's my best attempt at resolving #1586.
I've added a new section to the authoring spec specifically dealing with fragment identifiers and have linked down to it from the textref and src attributes.
I've specified that authors should reference a target element or use an svg fragid, but may use other schemes (noting that support is not required).
In the reading system specification, I've made the recommendation to ensure the element is visible contingent on one of the above two fragment identifier schemes being used.
Otherwise, I've made some minor cleanup to ensure we're not being too element-specific when talking about the fragments (plus some general cleanup since I was reading through the sections anyway).
Fully expect this will need some more tweaking, though. I'll add a change log entry once it's clear what we're settling on.
Fixes #1586
Preview | Diff