Make Service Worker registration work properly (don't use outdated steps) - #792
Conversation
| A {{Document}} may either be <dfn>installable</dfn> or not. The initial | ||
| state of a document is not <a>installable</a>. | ||
| </p> | ||
| <p> |
There was a problem hiding this comment.
Does this PR have unrelated changes? It seems so
There was a problem hiding this comment.
Ugh, yes, this is because GitHub doesn't respect upstream branches in Git. This PR is dependent on #790 which hasn't landed yet, and I don't think there's any way for GitHub to show just the relevant changes.
Please look at this delta.
|
@marcoscaceres While I'm on a roll with Manifest... Edit: Please look at this delta.
|
5a56e10 to
7a551e3
Compare
|
The upstream PR has now merged, so this PR's delta is correct. |
marcoscaceres
left a comment
There was a problem hiding this comment.
Approved with caveat the the service worker stuff will be deleted right after (as decided in #800).
|
Well Jeffrey (talked at TPAC) says to please not do that as he is going to use that innWeb Packaging which uses web app manifest |
|
@jyasskin could you comment? |
|
Sure, but the multi-implementer problem remains. Not sure at this point we want to support this in Gecko, but need to check if WebKit supports it. |
|
We might use the |
|
Ok, let's proceed with the plan to remove it... we can always bring it back. |
|
Oops, thanks for closing this out. |
This change (choose one):
changes normative sections without changing behavior)
Commit message:
Make Service Worker registration work properly (don't use outdated steps).
Closes #789.
Preview | Diff