Various fixes to ImageResource processing algorithms - #811
Merged
Conversation
Normative: - Removed passing the name of the member to the processing algorithm. It just directly takes the array of image resources. This fixes a mismatch between the callers (which were already passing the array) and the definition of the algorithm. - Removed definition of steps for processing "src". This was doing almost nothing; just inline the parsing of the URL. - Copy "platform" into the output array. Formatting: - Fixed links to "sizes" definition. - Remove redundant list in processing algorithm.
Collaborator
Author
|
@aarongustafson Please have a look at this. I noticed so many issues while reviewing w3c/image-resource#6 which were copied from here, that I think we should fix them upstream first (since they won't be deleted from Manifest for some time). If you wouldn't mind, can you copy the changes into w3c/image-resource#6 as well? (The commit description summarizes all the changes which you could make by hand.) |
aarongustafson
approved these changes
Oct 11, 2019
aarongustafson
left a comment
Collaborator
There was a problem hiding this comment.
LGTM. Given that most of this is going to be backed out once ImageResource is ready, I don’t think we need to get super particular about the naming of manifest URL/base URL vs. context, etc.
christianliebel
pushed a commit
to christianliebel/manifest
that referenced
this pull request
May 27, 2020
Normative: - Removed passing the name of the member to the processing algorithm. It just directly takes the array of image resources. This fixes a mismatch between the callers (which were already passing the array) and the definition of the algorithm. - Removed definition of steps for processing "src". This was doing almost nothing; just inline the parsing of the URL. - Copy "platform" into the output array. Formatting: - Fixed links to "sizes" definition. - Remove redundant list in processing algorithm.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change (choose one):
changes normative sections without changing behavior)
Commit message:
Normative:
just directly takes the array of image resources. This fixes a
mismatch between the callers (which were already passing the array)
and the definition of the algorithm.
almost nothing; just inline the parsing of the URL.
Formatting:
Preview | Diff