Use DOMPointInit argument for getCharNumAtPosition. #389 - #414
Merged
Conversation
AmeliaBR
reviewed
Apr 15, 2018
AmeliaBR
left a comment
Contributor
There was a problem hiding this comment.
See correction comment.
Were you going to change the isPointInStroke/Fill methods, too?
It would be nice to also support an Init input for the SVGPointList methods, but I think thats too much of a change of behavior at this point.
|
|
||
| <div class='changed-since-cr1'> | ||
| <ul> | ||
| <li>Specify <a>DOMPointInit</a> as argument type for getComputedTextLength() instead of |
Contributor
Author
|
Added requested changes. |
Contributor
Author
dstorey
reviewed
May 1, 2018
| <interface name='DOMPointReadOnly' href='https://www.w3.org/TR/2014/WD-geometry-1-20140522/#dom-dompointreadonly'/> | ||
| <interface name='SVGPoint' href='https://www.w3.org/TR/2014/CR-geometry-1-20141125/#dom-dompoint'/> | ||
| <interface name='DOMPoint' href='https://www.w3.org/TR/2014/CR-geometry-1-20141125/#dom-dompoint'/> | ||
| <interface name='DOMPointInit' href='https://www.w3.org/TR/2014/CR-geometry-1-20141125/#dictdef-dompointinit'/> |
Member
There was a problem hiding this comment.
Should we link to the bare https://www.w3.org/TR/geometry-1/ rather than a specific version that will become stale in time? (not sure what the official policy is on this but it always seems weird to me having links to old versions)
Contributor
Author
There was a problem hiding this comment.
Since we do it in many places now, I’d assume we should.
dstorey
approved these changes
May 1, 2018
dirkschulze
force-pushed
the
DOMPointInit-getCharNumAtPosition
branch
from
May 1, 2018 18:50
ff1e082 to
d22560f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.