Clean-up Changes appendix - #521
Merged
Merged
Conversation
(Since the people most frequently mentioned aren't active working group members anymore, anyway.)
- Make sure there's a section for every chapter & appendix from SVG 1.1, and every one in SVG 2, and indicate which is which. - Put a list of all the major re-organizations in the "Editorial Changes" section at the top. - Added a few other missing changes, and corrected a few others. - Removed the testing links for the Linking chapter (still to be determined where/how best else to include this, but probably not here).
Also revert the removal of change-log history related to z-index (while still making the final outcome clear), and make clear that its removal was a deferment.
svgeesus
reviewed
Aug 10, 2018
svgeesus
left a comment
Contributor
There was a problem hiding this comment.
This is much clearer. The (SVG 1.1 only / SVG 2 only) annotations are helpful; and the textual descriptions of chapter splits, merges and deletions are better.
svgeesus
reviewed
Aug 10, 2018
svgeesus
left a comment
Contributor
There was a problem hiding this comment.
Yeah these owners were kind of pointless.
svgeesus
reviewed
Aug 10, 2018
svgeesus
approved these changes
Aug 10, 2018
svgeesus
left a comment
Contributor
There was a problem hiding this comment.
Much better with the links to individual PRs and issue discussion.
Agree with your decision on z-index history.
Contributor
|
Good work! I also agree with the decision on z-index. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tidying up the changes appendix. See commit messages for details.
Shouldn't really be any normative changes here, but I'd appreciate someone else taking a quick look to make sure I haven't broken anything.
I suspect that I'll find a few more missing changes as I go through the rest of the implementation review. But, it's still probably better to merge this sooner rather than later, so that other PRs (which all change the changes appendix, of course) can be rebased over top.
Other PRs will also need minor edits to add links to issues and PRs, as well as annotations to indicate that they are changes since the August CR, so that the tidy-up can last more than a few days!