Skip to content

Change from HTML 5.1 to HTML LS, #514 - #544

Merged
svgeesus merged 32 commits into
masterfrom
514_html_refs
Sep 21, 2018
Merged

Change from HTML 5.1 to HTML LS, #514#544
svgeesus merged 32 commits into
masterfrom
514_html_refs

Conversation

@svgeesus

@svgeesus svgeesus commented Sep 17, 2018

Copy link
Copy Markdown
Contributor

Update all internal links to [HTML] which were linking to HTML 5.1 in the refs (with the wrong bibliographic reference). Actual [HTML51] was not found.

@svgeesus

svgeesus commented Sep 17, 2018

Copy link
Copy Markdown
Contributor Author

(do not merge yet, more commits incoming)

@svgeesus

Copy link
Copy Markdown
Contributor Author

ready for review

@AmeliaBR

Copy link
Copy Markdown
Contributor

Haven't reviewed yet, but: I think this might be a good use case for the "squash & merge" feature.

@svgeesus

Copy link
Copy Markdown
Contributor Author

Probably :) I thought small, single-purpose commits with meaningful names might be easier to check though

@svgeesus

Copy link
Copy Markdown
Contributor Author

Any other takers for a quick review?

@svgeesus

Copy link
Copy Markdown
Contributor Author

I think it is better to merge this now because other PR in the queue are likely to clobber it due to lots of text being moved around. The edits on this PR are very small and localized (updating hrefs from HTML5 to HTML LS)

@svgeesus
svgeesus merged commit 913662b into master Sep 21, 2018
@svgeesus
svgeesus deleted the 514_html_refs branch September 21, 2018 20:11
Comment thread master/render.html
<a href="conform.html">conformance requirements</a>.</p>
<p class="ready-for-wider-review">
As in HTML [<a href="refs.html#ref-html51">HTML</a>, 10.4.2],
As in HTML [<a href="refs.html#ref-html">HTML</a>, 10.4.2],

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With a belated review comment: that section number is wrong. Haven't tracked down the correct one.

If you have a chance, it could be fixed as a separate commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants