Add third party cookie relaxations for FedCM - #523
Conversation
|
Based on discussion, we will need #526 first before moving forward on this PR. |
npm1
left a comment
There was a problem hiding this comment.
This is ready for another review, ptal
f9798cb to
9824219
Compare
|
ptal |
| [=compute the connection status/connected=]. This check can be performed by iterating | ||
| over the [=connected accounts set=] or by keeping a separate data structure to make these | ||
| lookups faster. | ||
| * There is no third party cookie access for |configUrl|'s [=url/origin=] on |document|'s |
There was a problem hiding this comment.
we should swap this step with the configUrl parse check below, right?
There was a problem hiding this comment.
Ah yes since this uses configUrl, done
| 1. Let |idpOrigin| be the [=url/origin=] corresponding to |provider|'s | ||
| {{IdentityProviderConfig/configURL}}. | ||
| 1. Let |rpOrigin| be |globalObject|'s [=associated Document=]'s [=Document/origin=]. | ||
| 1. If |account| [=map/contains=] {{IdentityProviderAccount/approved_clients}}, |
There was a problem hiding this comment.
In step 1 above we have checked that the client id is on the list so this may not be needed.
There was a problem hiding this comment.
Step 1 checks whether the list exists and client_id is not present. So it is possible still for the list to not exist at this point.
There was a problem hiding this comment.
Right. Technically speaking we can omit the "approved_clients contains client_id" check here but maybe it's more readable this way? Up to you.
SHA: 540070a Reason: push, by npm1 Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
SHA: 540070a Reason: push, by pull[bot] Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Fixes #517
Preview | Diff