[Gecko Bug 1657345] Make grid container aware that its available block-size can be unconstrained in paginated context. - #25500
Merged
Merged
Conversation
…trained in paginated context. This happens when nsColumnSetFrame reflows its last column in an unconstrained available block-size. The wpt test can trigger the bug in a debug build easily. In opt builds like Nightly, if one wants to load the test manually, additional incremental reflow (such as opening devtools) may be needed to trigger the bug. Co-authored-by: Mats Palmgren <mats@mozilla.com> Differential Revision: https://phabricator.services.mozilla.com/D86672 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1657345 gecko-commit: f32d958a56b6139dbf35884edb7a6b9e37291970 gecko-reviewers: mats
wpt-pr-bot
approved these changes
Sep 12, 2020
wpt-pr-bot
left a comment
Collaborator
There was a problem hiding this comment.
The review process for this patch is being conducted in the Firefox project.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This happens when nsColumnSetFrame reflows its last column in an
unconstrained available block-size.
The wpt test can trigger the bug in a debug build easily. In opt builds like
Nightly, if one wants to load the test manually, additional incremental reflow
(such as opening devtools) may be needed to trigger the bug.
Co-authored-by: Mats Palmgren mats@mozilla.com
Differential Revision: https://phabricator.services.mozilla.com/D86672
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1657345
gecko-commit: f32d958a56b6139dbf35884edb7a6b9e37291970
gecko-reviewers: mats